no matching push files

[trobrock]

I just set up a pre-push hook to run my tests and I'm having some trouble. Most of the time it works, but it seems like when I do my first push to a new branch git push -u some-branch I get the following output:

 % gp -u origin weekly-upgrade 
╭────────────────────────────────────╮
│ 🥊 lefthook v1.5.5  hook: pre-push │
╰────────────────────────────────────╯
│  rspec (skip) no matching push files
                                      
  ────────────────────────────────────
summary: (skip) empty                 

My lefthook config is pretty simple:

pre-push:
  parallel: true
  commands:
    rspec:
      run: bundle exec rspec

Am I doing something wrong? I just want my tests to always run on a push.

[mrexox]

I assume that you push a branch that has no changes related to the main branch, so the pre-push hook commands are being skipped.

If I mistaken, please do the same thing with LEFTHOOK_VERBOSE=1 env variable set, so I could better understand what the problem is.

If I am right, this feels like a confusing behavior. I will add the not to documentation. Would you like to have an option to disable implicit skips in such situation?

[trobrock]

@mrexox here is the output, you can see I create a branch, make changes, commit them, then push those changes, but nothing runs:

[~/Sites/comfortly/inn_management] [main]
 % gco -b test-lefthook
Switched to a new branch 'test-lefthook'
[~/Sites/comfortly/inn_management] [test-lefthook]
 % gaa
[~/Sites/comfortly/inn_management] [test-lefthook *]
 % gss
M  app/controllers/application_controller.rb
[~/Sites/comfortly/inn_management] [test-lefthook *]
 % gc -m "Update application controller to test lefthook"
╭──────────────────────────────────────╮
│ 🥊 lefthook v1.5.5  hook: pre-commit │
╰──────────────────────────────────────╯
sync hooks: ✔️ (pre-commit, pre-push)
│  eslint (skip) no files for inspection
┃  rubocop ❯ 

Inspecting 1 file
.

1 file inspected, no offenses detected

                                      
  ────────────────────────────────────
summary: (done in 0.78 seconds)       
✔️  rubocop
[test-lefthook 3008687] Update application controller to test lefthook
 1 file changed, 4 insertions(+)
[~/Sites/comfortly/inn_management] [test-lefthook]
 % export LEFTHOOK_VERBOSE=1 
[~/Sites/comfortly/inn_management] [test-lefthook]
 % git push -u origin test-lefthook 
│ [lefthook] cmd: [git rev-parse --show-toplevel]
│ [lefthook] dir: 
│ [lefthook] err: <nil>
│ [lefthook] out: /Users/trobrock/Sites/comfortly/inn_management
                                                              
│ [lefthook] cmd: [git rev-parse --git-path hooks]
│ [lefthook] dir: 
│ [lefthook] err: <nil>
│ [lefthook] out: .git/hooks
                          
│ [lefthook] cmd: [git rev-parse --git-path info]
│ [lefthook] dir: 
│ [lefthook] err: <nil>
│ [lefthook] out: .git/info
                         
│ [lefthook] cmd: [git rev-parse --git-dir]
│ [lefthook] dir: 
│ [lefthook] err: <nil>
│ [lefthook] out: .git
                    
╭────────────────────────────────────╮
│ 🥊 lefthook v1.5.5  hook: pre-push │
╰────────────────────────────────────╯
│ [lefthook] cmd: [sh -c git diff --name-only HEAD @{push}]
│ [lefthook] dir: /Users/trobrock/Sites/comfortly/inn_management
│ [lefthook] err: exit status 128
│ [lefthook] out: fatal: no upstream configured for branch 'test-lefthook'
                                                                        
│ [lefthook] cmd: [sh -c git branch --remotes]
│ [lefthook] dir: /Users/trobrock/Sites/comfortly/inn_management
│ [lefthook] err: <nil>
│ [lefthook] out:   origin/admin-dashboard
  origin/ai-reviews                     
  origin/checklists                     
  origin/colorwow                       
  origin/digital-ocean-kamal            
  origin/disable-stay-overs             
  origin/fix-asset-url                  
  origin/main                           
  origin/mentions                       
  origin/new-ai-reviews                 
  origin/notifications                  
  origin/old                            
  origin/pause                          
  origin/pwa                            
  origin/review-copy                    
  origin/roles                          
  origin/service-worker-dev             
  origin/solid-queue                    
  origin/stripe-onboarding              
  origin/task-comments                  
  origin/tasks-filter-comment           
  origin/update-packages                
  origin/weekly-upgrade                 
                                        
│ [lefthook] cmd: [sh -c git diff --name-only HEAD ]
│ [lefthook] dir: /Users/trobrock/Sites/comfortly/inn_management
│ [lefthook] err: <nil>
│ [lefthook] out: 
│  rspec (skip) no matching push files
                                      
  ────────────────────────────────────
summary: (skip) empty                 
Enumerating objects: 9, done.
Counting objects: 100% (9/9), done.
Delta compression using up to 12 threads
Compressing objects: 100% (5/5), done.
Writing objects: 100% (5/5), 476 bytes | 476.00 KiB/s, done.
Total 5 (delta 4), reused 0 (delta 0), pack-reused 0
remote: Resolving deltas: 100% (4/4), completed with 4 local objects.
remote: 
remote: Create a pull request for 'test-lefthook' on GitHub by visiting:
remote:      https://github.com/getcomfortly/inn_management/pull/new/test-lefthook
remote: 
To https://github.com/getcomfortly/inn_management.git
 * [new branch]      test-lefthook -> test-lefthook
branch 'test-lefthook' set up to track 'origin/test-lefthook'.
[~/Sites/comfortly/inn_management] [test-lefthook]

Based on the output it seems like since it's not been pushed before it does not know which branch to diff it to?

[mrexox]

Thank you for the verbose logs. You are right, lefthook doesn't know what branch to use for the comparisson. For example, in case of lefthook repo I have the following output for git branch --remotes:

  fork/fix/uninstall-all-possible-formats
  fork/fix/use-empty-stdin-by-default
  fork/fix/windows-escaping-issues
  fork/master
  fork/refactoring
  origin/0-7-stable
  origin/HEAD -> origin/master
  origin/feat/add-priorities-to-commands
  origin/hyperupcall-recursive-search
  origin/master

In my case lefthook will use origin/master because origin/HEAD is pointing on it.

In your case you can fix it by git remote set-head origin main. But this is only if your repo has main as a default branch.

[mrexox]

Actually, the existing logic doesn't cover 100% of cases. Your case is one of those that are hard to handle. Also there can be no origin remote in a repo. That's confusing, but I don't have a working solution for this problem right now.

[trobrock]

Thanks! The set-head command works fine for me.