Support for relative roots/monorepos

[ffloyd]

For example, when you working with monorepo you may want to have config like this:

pre-commit:
  commands:
    elixir_format:
      root: "/backend"
      glob: "*.{ex,exs}"
      run: mix format --check-formatted {staged_files}
    ts_format:
      root: "/frontend"
      glob: "*.{ts,tsx}"
      run: npm run format_check {staged_files}

Possible root option behaviour:

• helpers like {staged_files} should return paths relative to provided root path
• option files should use root path as working dir
• option run should use root path as working dir

[Arkweid]

#38 ref

[schibrikov]

+1 for this issue. It's a huge pain to use eslint in monorepo now.
I guess I can work on this a bit later, if nobody will take care.

[Arkweid]

I give it a try in followng week

[dflock]

I'd really like to start using lefthook and this is a roadblock for us.

[Arkweid]

@sHooKDT makes I few changes for monorepos(big thanks), also root path in 0.6.5 now always related to git top.
Probable not a big changes we need to do to make it works:

1. Add new config key to the list (for root: "/backend")
   https://github.com/Arkweid/lefthook/blob/master/cmd/run.go#L42
2. Grab it from config file like this:
   https://github.com/Arkweid/lefthook/blob/master/cmd/run.go#L469-L472
3. Our runners now can be executed on some context(/backend, frontend)
   So we need to look at something like chdir https://golang.org/src/os/file.go?s=7660:7688#L251 or if you familiar with bash you can change sh -c i some way.
4. Double the code for _windows.go postfix files

[jsmestad]

I used @Arkweid's guidance to implement this in #98.

• {all_files} and {staged_files} will be relative to the root path specified
  • For example, root "api/" will change "api/spec/spec_helper.rb" to "./spec/spec_helper.rb"
  • Exclude files that do not fall inside of root (for example, "frontend/index.js" would be excluded from the task) - This functionality overlaps a little with glob, but I think that makes sense.
• Change directory into root when executing command

[Arkweid]

@sHooKDT @dflock @ffloyd
It would be great if someone will also check PR for existing project

[dflock]

I'll try to get to this today, Thanks!

…

On Thu., Dec. 12, 2019, 04:53 Abroskin Alexander, ***@***.***> wrote: @sHooKDT <https://github.com/sHooKDT> @dflock <https://github.com/dflock> @ffloyd <https://github.com/ffloyd> It would be great if someone will also check PR for existing project — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#72>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAALVDFMHUWACHH2DXZPNS3QYIX57ANCNFSM4ISL7L7A> .

[Arkweid]

Supoprt for monorepos released in v0.7.0, thanks @jsmestad

[CxRes]

Is there some documentation on how how to use Lefthook in monorepos?

[trajano]

@CxRes https://github.com/n8io/boilerplate-monorepo/blob/master/lefthook.yml