Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix execution on windows #108

Merged
merged 4 commits into from Jan 28, 2020
Merged

Fix execution on windows #108

merged 4 commits into from Jan 28, 2020

Conversation

lionskape
Copy link

@lionskape lionskape commented Jan 26, 2020 •
edited

removed sh from dependencies in root and add commands.

fixes #90
fixes #91

@lionskape lionskape changed the title Fix execution windows Fix execution on windows Jan 26, 2020
@lionskape lionskape force-pushed the fix/git-execution-conisistency_windows branch from b1f6985 to 4663f24 Compare January 27, 2020 00:03
Arkweid
Arkweid requested changes Jan 27, 2020
View reviewed changes
Copy link
Collaborator

@Arkweid Arkweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Please check my comments.

cmd/add.go Outdated Show resolved Hide resolved
cmd/root.go Outdated Show resolved Hide resolved
@Arkweid Arkweid merged commit 094d3f4 into evilmartians:master Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arkweid Arkweid Awaiting requested review from Arkweid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sh executable file not found lefthook version fails with exit status 128 outside of git repo
2 participants
@lionskape @Arkweid