Update uniseg #650
Merged
Update uniseg #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't understand how it could possibly be messing with stdin, but uniseg 0.2.0, which is a dependency of lipgloss, which we use for nicely colored logs... is causing stdin to be captured. Originally, I thought it was lipgloss, but there weren't any a huge diff, and nothing immediately jumped out. I did notice uniseg is a dependency, and was also updated. So I upgraded it on a whim, and it no longer swallos stdin :-|
|
Well, that's mysterious! But this is a great catch. Thank you for digging into it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes # #588
⚡ Summary
I don't understand how it could possibly be messing with stdin, but uniseg 0.2.0, which is a dependency of lipgloss, which we use for nicely colored logs... is causing stdin to be captured.
Originally, I thought it was lipgloss, but there weren't any a huge diff, and nothing immediately jumped out. I did notice uniseg is a dependency, and was also updated.
So I upgraded it on a whim, and it no longer swallows stdin 🙃
☑️ Checklist