Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Auto-Backup fails if one of the files is missing #391

Closed
deveth0 opened this issue Oct 25, 2019 · 2 comments
Closed

[BUG] Auto-Backup fails if one of the files is missing #391

deveth0 opened this issue Oct 25, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@deveth0
Copy link
Contributor

deveth0 commented Oct 25, 2019

Describe the bug
I'm not sure, how this situation came up but I don't have a .api-report.json file in /root and the auto-backup plugin therefor fails.
Probably it should check for each file first and only backup those files, that exist?
Other question: What should the api-report.json contain?

To Reproduce

  1. delete /root/.api-report.json
  2. activate auto-backup
  3. see failure

Expected behavior
Only existing files are backuped

Environment (please complete the following information):

  • Pwnagotchi version: 1.0.1

Additional context
Add any other context about the problem here.

@deveth0 deveth0 added the bug Something isn't working label Oct 25, 2019
@dadav
Copy link
Contributor

dadav commented Oct 25, 2019

Well, the plugin just executes the commands its given. We should change the default files to files which are 100% there. Api report is only there if the grid plugin is enabled..

@deveth0
Copy link
Contributor Author

deveth0 commented Oct 25, 2019

thx for the info. I created a PR which adds a simple check, if the file exists. I think this is a clear solution.

evilsocket added a commit that referenced this issue Oct 25, 2019
#391: Verify if the configured files exist
OnnoBuijsman pushed a commit to OnnoBuijsman/pwnagotchi that referenced this issue Oct 25, 2019
OnnoBuijsman pushed a commit to OnnoBuijsman/pwnagotchi that referenced this issue Oct 25, 2019
dadav pushed a commit to dadav/pwnagotchi that referenced this issue Apr 1, 2020
dadav pushed a commit to dadav/pwnagotchi that referenced this issue Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants