Add webcfg-Plugin, Reload config on USR1-sig, SharedConfig class and more... #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, big THX to Azkrath and RoM who helped with the html/javascript stuff^^ |
|
related issues: #206 |
Fixed typo in meta. Added typeof to ensure correct data types are enforced on inputs. Changed the load values from table to json to also ensure correct outputs.
Added a new button for the save configuration functionality.
dadav
force-pushed
the
feature/config_class
branch
from
dd31bfc
to
77b8739
Compare
neutralinsomniac
suggested changes
Nov 4, 2019
| @@ -44,16 +44,19 @@ def load_from_file(filename): | |||
| return plugin_name, instance | |||
|
|
|||
|
|
|||
| def load_from_path(path, enabled=()): | |||
| def load_from_path(path, enabled=list()): | |||
There was a problem hiding this comment.
So this is (probably) not gonna do what you want here. If you call this function with no 'enabled', argument, python will use the same (mutable) list object every time you call this function. Check this out:
https://docs.python-guide.org/writing/gotchas/
and my simple example:
test.py:
def wtf(arg=list()):
arg.append('a')
return arg
print wtf()
print wtf()
jeremy@x1:~/pwnagotchi$ python test.py
['a']
['a', 'a']
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, the first idea with the new on_webhook was to create a site in the browser to change the config. The problem was, that the config was all over the place (multiple threads etc.). This is the reason why i created the SharedConfig class. It stores the config in an internal dict, in one place, which allows us to change the config in all threads. What? Change things which are used by multiple threads? Yes, i know. Thats why there is a RWLock on it :)