Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistently use double quotes when possible. #120

Closed
wants to merge 1 commit into from
Closed

Consistently use double quotes when possible. #120

wants to merge 1 commit into from

Conversation

XhmikosR
Copy link
Contributor

No description provided.

@XhmikosR
Copy link
Contributor Author

Ping me after merging the other PRs so that I update this one.

Unfortunately, enabling JSHint's rule to enforce one quotes style, results in many warnings which I'm not sure anyone should bother at this point. But I can enable it if you agree.

@XhmikosR
Copy link
Contributor Author

XhmikosR commented Oct 5, 2013

PR updated

@evilstreak
Copy link
Owner

I'm happy with these changes but I don't think it's worthwhile merging them unless we can enforce use of double quotes via the test suite.

If you're able to fix the problem that JSHint's rule causes please reopen this PR.

@evilstreak evilstreak closed this Oct 5, 2013
@XhmikosR
Copy link
Contributor Author

XhmikosR commented Oct 5, 2013

Ofc we can. I simply didn't enforce double quotes because tests need some work. I will update the PR tomorrow and let someone else deal with the failing JSHint issues.

@XhmikosR
Copy link
Contributor Author

XhmikosR commented Oct 6, 2013

I can't reopen the PR myself, but I updated the branch. Tests will fail, feel free to merge and fix the remaining issues.

@ashb ashb reopened this Oct 6, 2013
@XhmikosR XhmikosR closed this May 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants