Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming conventions with releases #16

Open
jsturdy opened this issue Oct 23, 2017 · 0 comments
Open

Naming conventions with releases #16

jsturdy opened this issue Oct 23, 2017 · 0 comments

Comments

@jsturdy
Copy link
Contributor

jsturdy commented Oct 23, 2017

In the gemctp7user tools repo we rely on being able to specify a release version and getting the corresponding files.
Currently, this is muddled by mixing different era files within a given "release".
While understandable from a pre-release perspective, it would be best if when a release becomes "final" it always has the same convention.
The expectation (based on previous releases) is that this will always work:

    then
        echo "CTP7 firmware fw/gem_ctp7_v${ctp7fw//./_}_GBT.bit missing, downloading"
        echo "wget https://github.com/evka85/GEM_AMC/releases/download/v${ctp7fw}/gem_ctp7_v${ctp7fw//./_}_GBT.bit -O fw/gem_ctp7_v${ctp7fw//./_}_GBT.bit"
        wget https://github.com/evka85/GEM_AMC/releases/download/v${ctp7fw}/gem_ctp7_v${ctp7fw//./_}_GBT.bit -O fw/gem_ctp7_v${ctp7fw//./_}_GBT.bit
    fi

    echo "ln -sf gem_ctp7_v${ctp7fw//./_}_GBT.bit fw/gem_ctp7.bit"
    ln -sf gem_ctp7_v${ctp7fw//./_}_GBT.bit fw/gem_ctp7.bit

    if [ ! -f "xml/gem_amc_top_${ctp7fw//./_}.xml" ]
    then
        echo "CTP7 firmware xml/gem_amc_top_${ctp7fw//./_}.xml missing, downloading"
        echo "wget https://github.com/evka85/GEM_AMC/releases/download/v${ctp7fw}/address_table_v${ctp7fw//./_}_GBT.zip"
        wget https://github.com/evka85/GEM_AMC/releases/download/v${ctp7fw}/address_table_v${ctp7fw//./_}_GBT.zip
        echo "unzip address_table_v${ctp7fw//./_}_GBT.zip"
        unzip address_table_v${ctp7fw//./_}_GBT.zip
        echo "cp address_table_v${ctp7fw//./_}_GBT/gem_amc_top.xml xml/gem_amc_v${ctp7fw//./_}.xml"
        cp address_table_v${ctp7fw//./_}_GBT/gem_amc_top.xml xml/gem_amc_v${ctp7fw//./_}.xml
        echo "rm -rf address_table_v${ctp7fw//./_}_GBT"
        rm -rf address_table_v${ctp7fw//./_}_GBT
    fi

If some of this is obsolete (i.e.,, using the _GBT suffix), that's fine, but the general structure needs to be consistent (see also cms-gem-daq-project/xhal#27)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant