Add support for CRLF files #36
Conversation
There was a problem hiding this comment.
I was expecting a change around here somewhere too
https://github.com/evmar/n2/blob/main/src/depfile.rs#L38
Is it possible your .d files are not crlf?
Or you don't have .d files at all?
src/parse.rs
Outdated
| let mut buf = " | ||
| var = 3 | ||
| default a b$var c | ||
| let mut buf = "\r\n |
There was a problem hiding this comment.
I think the \r\n behavior would be better as its own test.
There was a problem hiding this comment.
I've now made a function test_for_line_endings, which tests some Input for both line endings. I hope it's okay, since this prevents test code duplication.
Answering my own question, on Windows you likely don't have .d files, so don't worry about this part. |
|
Thanks! |
|
BTW, I wanted to warn you that the Windows support is still pretty unfinished: |
This is crucial to support Windows. Since I'm not that familiar with the Ninja syntax, I don't really know how to test this in depth.
I have only changed the
parse_defaultsto using CRLF and tested it on the CMake Ninja test file, which at least doesn't fail because of CRLF anymore 馃槈