You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
switch next/link to a simple 'a'. The reason being, next link is intended for internal navigation, which means it will account for the basePath next config.
added a convenience method to make navigation works locally too
Side note: there's a flag disabling the security/detect-object-injection. In my other pr that addresses eslint setup, I disabled that globally.
The reasons I think that should be disabled are:
This rule is extremely strict. It basically disallow any way of accessing an objects prop dynamically even though there is no other way of doing that that would not trigger this error.
The workaround suggested online is to replace something like obj[dynamicKey] by obj[`${dynamicKey}`]. This though is not any safer, this is probably just bypassing the lint rule check
I'm the original author of this rule - for a bit of context, it was originally written as an assistive tool for manual code reviews, to be used with the eslint plugin for VS Code. I would recommend disabling it for other use cases, as it's just going to be far too noisy.
If we don't want to completely disable that, I'd suggest having it enabled for vscode, but disabled at the actual check. Although, personally, I'd just disable it
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changes here are:
basePath
next config.Side note: there's a flag disabling the
security/detect-object-injection
. In my other pr that addresses eslint setup, I disabled that globally.The reasons I think that should be disabled are:
obj[dynamicKey]
byobj[`${dynamicKey}`]
. This though is not any safer, this is probably just bypassing the lint rule checkIf we don't want to completely disable that, I'd suggest having it enabled for vscode, but disabled at the actual check. Although, personally, I'd just disable it