Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

london hardfork check logic in json-rpc is not consistent with chain state #1067

Closed
yihuang opened this issue Apr 29, 2022 · 0 comments · Fixed by #1068
Closed

london hardfork check logic in json-rpc is not consistent with chain state #1067

yihuang opened this issue Apr 29, 2022 · 0 comments · Fixed by #1068

Comments

@yihuang
Copy link
Contributor

yihuang commented Apr 29, 2022

System info: ethermint main

Steps to reproduce:

  1. Start a chain with london hardfork disabled
  2. Do a upgrade or gov proposal to set london_block to 0.
  3. Query historical block with jsonrpc getBlockByNumber.
  4. It'll treat the historical block as london block.

Expected behavior: it should match what's on the chain state.

Actual behavior: [What actually happened]

Additional info:

I think we can add BaseFee grpc query in evm module, which will check both london hardfork and feemarket module parameters. and json-rpc side call it with ContextWithHeight.

yihuang added a commit to yihuang/ethermint that referenced this issue Apr 29, 2022
Closes: evmos#1067
Solution:
- Add `BaseFee` grpc query handler in evm module which also checks the current london hardfork status.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant