Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Test transaction hash compatible with ethereum #209

Closed
yihuang opened this issue Jun 30, 2021 · 4 comments
Closed

Test transaction hash compatible with ethereum #209

yihuang opened this issue Jun 30, 2021 · 4 comments
Labels
Type: Tests issues and PR related to tests
Projects
Core

Comments

@yihuang
Copy link
Contributor

yihuang commented Jun 30, 2021

Probably in an integration test framework.
@yihuang yihuang mentioned this issue Jun 30, 2021
Merged
11 tasks
@fedekunze fedekunze added the Type: Tests issues and PR related to tests label Jun 30, 2021
@fedekunze fedekunze added this to Triage in Core via automation Jun 30, 2021
@yihuang
Copy link
Contributor Author

yihuang commented Jul 9, 2021 •
edited

It's verified in local testing, we just lack an integration test framework in CI

@github-actions
Copy link

This issue is stale because it has been open 45 days with no activity. Remove Status: Stale label or comment or this will be closed in 7 days.

@fedekunze
Copy link
Contributor

@yihuang maybe creating a unit test would suffice?

@yihuang
Copy link
Contributor Author

yihuang commented Sep 8, 2021

maybe not necessary, since it's using the same code.

@yihuang yihuang closed this as completed Sep 8, 2021
Core automation moved this from Triage to Done Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Type: Tests issues and PR related to tests
Projects
No open projects
Core
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yihuang @fedekunze