This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
gas estimation is not accurate #268
Assignees
Comments
|
this is the value for estimate gas i'm wondering why the difference comes from? |
|
I guess the tharsis is the fully refunded one, while the ganache is the real peak gas limit needed to run the tx. |
yihuang
referenced
this issue
in yihuang/ethermint
Jul 13, 2021
Closes #268 - Also refactor ApplyMessage to be more reuseable move binary search to rpc api side to have a clean context each try remove EstimateGas grpc api
yihuang
referenced
this issue
in yihuang/ethermint
Jul 15, 2021
Closes #268 - Also refactor ApplyMessage to be more reuseable move binary search to rpc api side to have a clean context each try remove EstimateGas grpc api
yihuang
referenced
this issue
in crypto-org-chain/ethermint
Jul 16, 2021
Closes #268 - Also refactor ApplyMessage to be more reuseable move binary search to rpc api side to have a clean context each try remove EstimateGas grpc api extract BinSearch function and add unit test
fedekunze
added a commit
that referenced
this issue
Jul 19, 2021
* do binary search to estimate gas Closes #268 - Also refactor ApplyMessage to be more reuseable move binary search to rpc api side to have a clean context each try remove EstimateGas grpc api * extract BinSearch function and add unit test * do estimateGas in grpc query Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
System info: ethermint main branch
Steps to reproduce:
Expected behavior: should just work
Actual behavior: run out of gas
Additional info:
Might have to do a binary search like go-ethereum.
Because the gasUsed returned by
EthCallis not the peak gas needed during execution, due to different kinds of gas refund.The text was updated successfully, but these errors were encountered: