This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
Problem: eth_newPendingTransactionFilter don't return correct tx hash #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes: evmos#1011 Solution: - use eth tx hash rather than tendermint one
yihuang
requested review from
fedekunze,
khoslaventures and
jolube
as code owners
fedekunze
reviewed
Mar 22, 2022
|
@yihuang can you also create a test to prevent this from failing again? |
yihuang
commented
Mar 23, 2022
done, added an e2e test. |
fedekunze
approved these changes
Mar 24, 2022
yihuang
commented
Mar 24, 2022
yihuang
commented
Mar 24, 2022
yihuang
commented
Mar 24, 2022
auto-merge was automatically disabled
March 24, 2022 07:50
Head branch was pushed to by a user without write access
auto-merge was automatically disabled
March 24, 2022 07:50
Head branch was pushed to by a user without write access
yihuang
added a commit
to yihuang/ethermint
that referenced
this pull request
Mar 24, 2022
evmos#1012) * Problem: eth_newPendingTransactionFilter don't return correct tx hash Closes: evmos#1011 Solution: - use eth tx hash rather than tendermint one * changelog * remove copied TODO comment and ignore err result of Notify * add e2e test * fix ws client in e2e test * fix test * Apply suggestions from code review * Apply suggestions from code review Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
yihuang
added a commit
to yihuang/ethermint
that referenced
this pull request
Mar 24, 2022
evmos#1012) * Problem: eth_newPendingTransactionFilter don't return correct tx hash Closes: evmos#1011 Solution: - use eth tx hash rather than tendermint one * changelog * remove copied TODO comment and ignore err result of Notify * add e2e test * fix ws client in e2e test * fix test * Apply suggestions from code review * Apply suggestions from code review Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #1011
Solution:
tested with this integration test: https://github.com/crypto-org-chain/cronos/pull/404/files#diff-126ee319c6fd3229b0d12d6e6110955bd64ea6a419086f618a06dedd1234fc68R15
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)