Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Context block height fix on TraceTx #1051

Merged
merged 5 commits into from
Apr 16, 2022
Merged

Conversation

crypto-facs
Copy link
Contributor

Closes: #XXX

Description

Fixes issue with context block height and removes unnecessary property on QueryTraceTxRequest . It is a API breaking change.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@crypto-facs crypto-facs changed the title Trace fix Context block height fix on TraceTx Apr 14, 2022
@codecov
Copy link

codecov bot commented Apr 14, 2022

Codecov Report

Merging #1051 (5985c96) into main (7509903) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1051      +/-   ##
==========================================
+ Coverage   60.87%   60.93%   +0.05%     
==========================================
  Files          80       80              
  Lines        6584     6594      +10     
==========================================
+ Hits         4008     4018      +10     
  Misses       2365     2365              
  Partials      211      211              
Impacted Files Coverage Δ
x/evm/keeper/grpc_query.go 68.30% <100.00%> (+0.76%) ⬆️

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, minor comment

proto/ethermint/evm/v1/query.proto Show resolved Hide resolved
@fedekunze fedekunze merged commit bc4b018 into evmos:main Apr 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants