Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

imp(rpc): restrict unprotected txs on the node RPC #1143

Merged
merged 6 commits into from Jun 22, 2022
Merged

imp(rpc): restrict unprotected txs on the node RPC #1143

merged 6 commits into from Jun 22, 2022

Conversation

fedekunze
Copy link
Contributor

Closes: #XXX

Description

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@fedekunze fedekunze marked this pull request as ready for review June 21, 2022 15:52
crypto-facs
crypto-facs suggested changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@crypto-facs crypto-facs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It LGTM but I believe we have to protect SendRawTransaction as well

@fedekunze fedekunze requested a review from danburck June 22, 2022 08:43
@fedekunze fedekunze merged commit 3b852f7 into main Jun 22, 2022
@fedekunze fedekunze deleted the fedekunze/unprotected-rpc branch June 22, 2022 10:50
devon-chain pushed a commit to FunctionX/ethermint that referenced this pull request Jun 28, 2022
@fedekunze @devon-chain
imp(rpc): restrict unprotected txs on the node RPC (evmos#1143)
3863a0a 
* imp(rpc): restrict unprotected txs on the node RPC

* lint

* send raw transaction

* c++
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crypto-facs crypto-facs crypto-facs approved these changes

@khoslaventures khoslaventures Awaiting requested review from khoslaventures

@jolube jolube Awaiting requested review from jolube

@danburck danburck Awaiting requested review from danburck

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fedekunze @crypto-facs