Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

optimize eth_getBalance endpoint #1169

Merged
merged 5 commits into from Jul 11, 2022
Merged

optimize eth_getBalance endpoint #1169

merged 5 commits into from Jul 11, 2022

Conversation

crypto-facs
Copy link
Contributor

Closes: #XXX

Description

small PR to optimize eth_getBalance rpc endpoint

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

fedekunze
fedekunze approved these changes Jul 8, 2022
View reviewed changes
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Freddy! Can you add a bug fix changelog entry?

rpc/backend/evm_backend.go Show resolved Hide resolved
@fedekunze fedekunze enabled auto-merge (squash) July 11, 2022 14:59
@fedekunze fedekunze merged commit da8fcc3 into evmos:main Jul 11, 2022
danburck pushed a commit that referenced this pull request Jul 12, 2022
@crypto-facs @fedekunze @danburck
fix(rpc): optimize eth_getBalance endpoint (#1169)
40db44d 
* optimize get balance endpoint

* add comment

* add changelog

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
@danburck danburck mentioned this pull request Jul 12, 2022
Merged
danburck pushed a commit that referenced this pull request Jul 12, 2022
@crypto-facs @fedekunze @danburck
fix(rpc): optimize eth_getBalance endpoint (#1169)
f2bd4e7 
* optimize get balance endpoint

* add comment

* add changelog

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
@danburck danburck mentioned this pull request Jul 12, 2022
Merged
danburck pushed a commit that referenced this pull request Jul 13, 2022
@crypto-facs @fedekunze @danburck
fix(rpc): optimize eth_getBalance endpoint (#1169)
53241cb 
* optimize get balance endpoint

* add comment

* add changelog

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
danburck pushed a commit that referenced this pull request Jul 13, 2022
@crypto-facs @fedekunze @danburck
fix(rpc): optimize eth_getBalance endpoint (#1169)
3532b47 
* optimize get balance endpoint

* add comment

* add changelog

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
danburck pushed a commit that referenced this pull request Jul 13, 2022
@crypto-facs @fedekunze @danburck
fix(rpc): optimize eth_getBalance endpoint (#1169)
68d09df 
* optimize get balance endpoint

* add comment

* add changelog

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
danburck pushed a commit that referenced this pull request Jul 13, 2022
@crypto-facs @fedekunze @danburck
fix(rpc): optimize eth_getBalance endpoint (#1169)
9f89944 
* optimize get balance endpoint

* add comment

* add changelog

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
This was referenced Jul 13, 2022
Merged
Merged
Merged
Merged
danburck added a commit that referenced this pull request Jul 13, 2022
@danburck @crypto-facs @fedekunze
release: v0.14.1 changelog and backport (#1183)
c2b10c4 
* fix(rpc): optimize `eth_getBalance` endpoint (#1169)

* optimize get balance endpoint

* add comment

* add changelog

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

* add backport changes

Co-authored-by: crypto-facs <84574577+crypto-facs@users.noreply.github.com>
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
danburck added a commit that referenced this pull request Jul 13, 2022
@danburck @crypto-facs @fedekunze
fix(rpc): optimize eth_getBalance endpoint (#1169) (#1182)
aba4198 
* optimize get balance endpoint

* add comment

* add changelog

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

Co-authored-by: crypto-facs <84574577+crypto-facs@users.noreply.github.com>
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
danburck added a commit that referenced this pull request Jul 13, 2022
@danburck @crypto-facs @fedekunze
fix(rpc): optimize eth_getBalance endpoint (#1169) (#1181)
dcfb798 
* optimize get balance endpoint

* add comment

* add changelog

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

Co-authored-by: crypto-facs <84574577+crypto-facs@users.noreply.github.com>
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
danburck added a commit that referenced this pull request Jul 13, 2022
@danburck @crypto-facs @fedekunze
fix(rpc): optimize eth_getBalance endpoint (#1169) (#1180)
922c273 
* optimize get balance endpoint

* add comment

* add changelog

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

Co-authored-by: crypto-facs <84574577+crypto-facs@users.noreply.github.com>
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
hoanguyenkh pushed a commit to AstraProtocol/ethermint that referenced this pull request Jul 27, 2022
@crypto-facs @fedekunze
fix(rpc): optimize eth_getBalance endpoint (evmos#1169)
c0885e2 
* optimize get balance endpoint

* add comment

* add changelog

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
hoanguyenkh pushed a commit to AstraProtocol/ethermint that referenced this pull request Jul 27, 2022
@danburck @crypto-facs @fedekunze
fix(rpc): optimize eth_getBalance endpoint (evmos#1169) (evmos#1180)
293fcbe 
* optimize get balance endpoint

* add comment

* add changelog

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

Co-authored-by: crypto-facs <84574577+crypto-facs@users.noreply.github.com>
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
devon-chain pushed a commit to devon-chain/ethermint that referenced this pull request Aug 2, 2022
@crypto-facs @fedekunze @devon-chain
fix(rpc): optimize eth_getBalance endpoint (evmos#1169)
69b0aba 
* optimize get balance endpoint

* add comment

* add changelog

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
devon-chain pushed a commit to FunctionX/ethermint that referenced this pull request Nov 17, 2022
@crypto-facs @fedekunze @devon-chain
fix(rpc): optimize eth_getBalance endpoint (evmos#1169)
1b640f8 
* optimize get balance endpoint

* add comment

* add changelog

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fedekunze fedekunze fedekunze approved these changes

@khoslaventures khoslaventures Awaiting requested review from khoslaventures

@jolube jolube Awaiting requested review from jolube

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@crypto-facs @fedekunze