This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
impr(evm): add check msg.Validate check to prevent 0 gas txs #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1174 +/- ##
==========================================
+ Coverage 62.06% 62.25% +0.19%
==========================================
Files 91 91
Lines 7355 7358 +3
==========================================
+ Hits 4565 4581 +16
+ Misses 2562 2551 -11
+ Partials 228 226 -2
|
danburck
requested review from
fedekunze,
khoslaventures and
jolube
as code owners
fedekunze
reviewed
Jul 11, 2022
ramacarlucho
approved these changes
Jul 18, 2022
fedekunze
approved these changes
Jul 18, 2022
hoanguyenkh
pushed a commit
to AstraProtocol/ethermint
that referenced
this pull request
Jul 27, 2022
) * impr(evm): add check msg.Validate check to prevent 0 gas txs * add changelog * impr(evm): add integration tests for zero gas txs * go mod tidy and proto swagger * fix comment * move changelog to state machine breaking * add ReadHeaderTimeout` * revert ReadHeaderTimeout config change Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a
MsgEthereumTxmsg validation to prevent the spam through 0 gas txs. It also adds a integration test suite to the evm module.Closes: ENG-541 https://linear.app/evmos/issue/ENG-541/devs-can-spamdos-a-network-by-submitting-a-many-txs-with-0-gas