This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
fix: add authz ante handler #1741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You have successfully added a new Semgrep configuration |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1741 +/- ##
==========================================
+ Coverage 67.94% 68.05% +0.11%
==========================================
Files 112 113 +1
Lines 10209 10263 +54
==========================================
+ Hits 6936 6984 +48
- Misses 2865 2869 +4
- Partials 408 410 +2
|
0a1c
suggested changes
Apr 6, 2023
| ) | ||
| suite.Require().NoError(err) | ||
|
|
||
| header := suite.ctx.BlockHeader() |
0a1c
approved these changes
Apr 6, 2023
facs95
commented
Apr 10, 2023
| @@ -25,39 +25,42 @@ import ( | |||
| ) | |||
|
|
|||
| // maxNestedMsgs defines a cap for the number of nested messages on a MsgExec message | |||
| const maxNestedMsgs = 7 | |||
| const maxNestedMsgs = 6 | |||
There was a problem hiding this comment.
Why the change to 6 ?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
Description
Adds authz ante check with the corresponding tests. Starts the process of reorganizing tests based on the work done on Evmos.
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)