Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

benchmark evm message calls #717

Merged
merged 2 commits into from
Nov 8, 2021
Merged

benchmark evm message calls #717

merged 2 commits into from
Nov 8, 2021

Conversation

yihuang
Copy link
Contributor

@yihuang yihuang commented Nov 2, 2021

Description

Showcase the performance issue in #710


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@fedekunze fedekunze enabled auto-merge (squash) November 3, 2021 12:40
@fedekunze fedekunze added the Type: Tests issues and PR related to tests label Nov 3, 2021
@yihuang
Copy link
Contributor Author

yihuang commented Nov 3, 2021

It breaks many unit tests by changing existing contract, I guess it's better for me to create a new contract.

auto-merge was automatically disabled November 8, 2021 10:41

Head branch was pushed to by a user without write access

@yihuang
Copy link
Contributor Author

yihuang commented Nov 8, 2021

It breaks many unit tests by changing existing contract, I guess it's better for me to create a new contract.

done, unit test passes now. @fedekunze

@codecov
Copy link

codecov bot commented Nov 8, 2021

Codecov Report

Merging #717 (2c56398) into main (fd36873) will decrease coverage by 0.03%.
The diff coverage is 20.00%.

❗ Current head 2c56398 differs from pull request most recent head 2006f52. Consider uploading reports for the commit 2006f52 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #717      +/-   ##
==========================================
- Coverage   56.41%   56.38%   -0.04%     
==========================================
  Files          64       64              
  Lines        5637     5642       +5     
==========================================
+ Hits         3180     3181       +1     
- Misses       2271     2273       +2     
- Partials      186      188       +2     
Impacted Files Coverage Δ
x/evm/types/compiled_contract.go 29.26% <20.00%> (-1.29%) ⬇️

@fedekunze fedekunze enabled auto-merge (squash) November 8, 2021 13:01
@fedekunze fedekunze merged commit 7c7f3f0 into evmos:main Nov 8, 2021
@yihuang yihuang deleted the bench-tx branch November 8, 2021 13:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Tests issues and PR related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants