Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Problem: need to add JSON-RPC endpoint debug_intermediateRoots #754

Merged
merged 3 commits into from Nov 16, 2021
Merged

Problem: need to add JSON-RPC endpoint debug_intermediateRoots #754

merged 3 commits into from Nov 16, 2021

Conversation

adu-web3
Copy link
Contributor

@adu-web3 adu-web3 commented Nov 16, 2021 •
edited

Closes #715

  • currently return emtpy hash

Closes: #XXX

Description

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

fedekunze
fedekunze approved these changes Nov 16, 2021
View reviewed changes
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@fedekunze fedekunze added the C:JSON-RPC JSON-RPC client label Nov 16, 2021
@fedekunze fedekunze enabled auto-merge (squash) November 16, 2021 14:22
@fedekunze fedekunze merged commit e96a4b9 into evmos:main Nov 16, 2021
@adu-web3 adu-web3 deleted the debug_intermediateRoots branch November 17, 2021 02:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fedekunze fedekunze fedekunze approved these changes

@jolube jolube Awaiting requested review from jolube

@khoslaventures khoslaventures Awaiting requested review from khoslaventures

Assignees
No one assigned
Labels
C:JSON-RPC JSON-RPC client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem: need to add rpc method debug_intermediateRoots
2 participants
@adu-web3 @fedekunze