This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
RPC tests are failing if FeeMarket Base Fee is enabled by default #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danburck
requested review from
fedekunze,
jolube and
khoslaventures
as code owners
Codecov Report
@@ Coverage Diff @@
## main #770 +/- ##
=======================================
Coverage 57.45% 57.45%
=======================================
Files 71 71
Lines 6107 6107
=======================================
Hits 3509 3509
Misses 2396 2396
Partials 202 202
|
|
Thanks to @crypto-facs for finding the fix and removed the hardcoded |
danburck
changed the title
fedekunze
deleted the
ENG-273-rpc-tests-fail-with-enabled-FeeMarket-BaseFee
branch
Merged
fedekunze
added a commit
that referenced
this pull request
Nov 23, 2021
* docs: update changelog (#765) * feemarket: unit tests EIP1559 (#758) * Fee-Market(Types): Setup Params tests * Fee-Market(Types): Add all Params tests * Fee-Market(Types): Add genesis tests * Fee-Market(Keeper): Copy Keeper setup from EVM module and add Params tests * Fee-Market(Keeper): Add Keeper tests * Fee-Market(Keeper): Add review comments * Fee-Market(Keeper): WIP grpc tests * Fee-Market(Keeper): WIP ERIP1559 tests * Fee-Market(Keeper): WIP ERIP1559 tests * Fee-Market(Keeper): WIP ERIP1559 tests maxGas influences on baseFee * Fee-Market(Keeper): Add last ERIP1559 tests * Fee-Market(Keeper): Add abci tests * rpc: fix default signer (#769) * rpc: fix default signer * changelog * build(deps): bump actions/cache from 2.1.6 to 2.1.7 (#772) Bumps [actions/cache](https://github.com/actions/cache) from 2.1.6 to 2.1.7. - [Release notes](https://github.com/actions/cache/releases) - [Commits](actions/cache@v2.1.6...v2.1.7) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: RPC tests fail if FeeMarket `BaseFee` is enabled by default (#770) * Fix(FeeMarket): Enable FeeMarkat BaseFee * fix rpc tests * changelog Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Freddy Caceres <freddy.caceres@crypto.com> Co-authored-by: Federico Kunze Küllmer <federico.kunze94@gmail.com> * changelog Co-authored-by: Daniel Burckhardt <daniel.m.burckhardt@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Freddy Caceres <freddy.caceres@crypto.com>
fedekunze
added a commit
that referenced
this pull request
Dec 1, 2021
* release: `v0.8.0` changelog (#757) * release: v0.8.1 changes (#775) * docs: update changelog (#765) * feemarket: unit tests EIP1559 (#758) * Fee-Market(Types): Setup Params tests * Fee-Market(Types): Add all Params tests * Fee-Market(Types): Add genesis tests * Fee-Market(Keeper): Copy Keeper setup from EVM module and add Params tests * Fee-Market(Keeper): Add Keeper tests * Fee-Market(Keeper): Add review comments * Fee-Market(Keeper): WIP grpc tests * Fee-Market(Keeper): WIP ERIP1559 tests * Fee-Market(Keeper): WIP ERIP1559 tests * Fee-Market(Keeper): WIP ERIP1559 tests maxGas influences on baseFee * Fee-Market(Keeper): Add last ERIP1559 tests * Fee-Market(Keeper): Add abci tests * rpc: fix default signer (#769) * rpc: fix default signer * changelog * build(deps): bump actions/cache from 2.1.6 to 2.1.7 (#772) Bumps [actions/cache](https://github.com/actions/cache) from 2.1.6 to 2.1.7. - [Release notes](https://github.com/actions/cache/releases) - [Commits](actions/cache@v2.1.6...v2.1.7) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: RPC tests fail if FeeMarket `BaseFee` is enabled by default (#770) * Fix(FeeMarket): Enable FeeMarkat BaseFee * fix rpc tests * changelog Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Freddy Caceres <freddy.caceres@crypto.com> Co-authored-by: Federico Kunze Küllmer <federico.kunze94@gmail.com> * changelog Co-authored-by: Daniel Burckhardt <daniel.m.burckhardt@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Freddy Caceres <freddy.caceres@crypto.com> * changelog Co-authored-by: Daniel Burckhardt <daniel.m.burckhardt@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Freddy Caceres <freddy.caceres@crypto.com>
fedekunze
added a commit
that referenced
this pull request
Dec 1, 2021
* release: `v0.8.0` changelog (#757) * release: v0.8.1 changes (#775) * docs: update changelog (#765) * feemarket: unit tests EIP1559 (#758) * Fee-Market(Types): Setup Params tests * Fee-Market(Types): Add all Params tests * Fee-Market(Types): Add genesis tests * Fee-Market(Keeper): Copy Keeper setup from EVM module and add Params tests * Fee-Market(Keeper): Add Keeper tests * Fee-Market(Keeper): Add review comments * Fee-Market(Keeper): WIP grpc tests * Fee-Market(Keeper): WIP ERIP1559 tests * Fee-Market(Keeper): WIP ERIP1559 tests * Fee-Market(Keeper): WIP ERIP1559 tests maxGas influences on baseFee * Fee-Market(Keeper): Add last ERIP1559 tests * Fee-Market(Keeper): Add abci tests * rpc: fix default signer (#769) * rpc: fix default signer * changelog * build(deps): bump actions/cache from 2.1.6 to 2.1.7 (#772) Bumps [actions/cache](https://github.com/actions/cache) from 2.1.6 to 2.1.7. - [Release notes](https://github.com/actions/cache/releases) - [Commits](actions/cache@v2.1.6...v2.1.7) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: RPC tests fail if FeeMarket `BaseFee` is enabled by default (#770) * Fix(FeeMarket): Enable FeeMarkat BaseFee * fix rpc tests * changelog Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Freddy Caceres <freddy.caceres@crypto.com> Co-authored-by: Federico Kunze Küllmer <federico.kunze94@gmail.com> * changelog Co-authored-by: Daniel Burckhardt <daniel.m.burckhardt@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Freddy Caceres <freddy.caceres@crypto.com> * changelog `v0.8.1` (#805) * release: `v0.8.0` changelog (#757) * release: v0.8.1 changes (#775) * docs: update changelog (#765) * feemarket: unit tests EIP1559 (#758) * Fee-Market(Types): Setup Params tests * Fee-Market(Types): Add all Params tests * Fee-Market(Types): Add genesis tests * Fee-Market(Keeper): Copy Keeper setup from EVM module and add Params tests * Fee-Market(Keeper): Add Keeper tests * Fee-Market(Keeper): Add review comments * Fee-Market(Keeper): WIP grpc tests * Fee-Market(Keeper): WIP ERIP1559 tests * Fee-Market(Keeper): WIP ERIP1559 tests * Fee-Market(Keeper): WIP ERIP1559 tests maxGas influences on baseFee * Fee-Market(Keeper): Add last ERIP1559 tests * Fee-Market(Keeper): Add abci tests * rpc: fix default signer (#769) * rpc: fix default signer * changelog * build(deps): bump actions/cache from 2.1.6 to 2.1.7 (#772) Bumps [actions/cache](https://github.com/actions/cache) from 2.1.6 to 2.1.7. - [Release notes](https://github.com/actions/cache/releases) - [Commits](actions/cache@v2.1.6...v2.1.7) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: RPC tests fail if FeeMarket `BaseFee` is enabled by default (#770) * Fix(FeeMarket): Enable FeeMarkat BaseFee * fix rpc tests * changelog Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Freddy Caceres <freddy.caceres@crypto.com> Co-authored-by: Federico Kunze Küllmer <federico.kunze94@gmail.com> * changelog Co-authored-by: Daniel Burckhardt <daniel.m.burckhardt@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Freddy Caceres <freddy.caceres@crypto.com> * changelog Co-authored-by: Daniel Burckhardt <daniel.m.burckhardt@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Freddy Caceres <freddy.caceres@crypto.com> * changelog Co-authored-by: Daniel Burckhardt <daniel.m.burckhardt@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Freddy Caceres <freddy.caceres@crypto.com>
fedekunze
added a commit
that referenced
this pull request
Dec 1, 2021
* release: changelog `v0.9.0` (#806) * release: `v0.8.0` changelog (#757) * release: v0.8.1 changes (#775) * docs: update changelog (#765) * feemarket: unit tests EIP1559 (#758) * Fee-Market(Types): Setup Params tests * Fee-Market(Types): Add all Params tests * Fee-Market(Types): Add genesis tests * Fee-Market(Keeper): Copy Keeper setup from EVM module and add Params tests * Fee-Market(Keeper): Add Keeper tests * Fee-Market(Keeper): Add review comments * Fee-Market(Keeper): WIP grpc tests * Fee-Market(Keeper): WIP ERIP1559 tests * Fee-Market(Keeper): WIP ERIP1559 tests * Fee-Market(Keeper): WIP ERIP1559 tests maxGas influences on baseFee * Fee-Market(Keeper): Add last ERIP1559 tests * Fee-Market(Keeper): Add abci tests * rpc: fix default signer (#769) * rpc: fix default signer * changelog * build(deps): bump actions/cache from 2.1.6 to 2.1.7 (#772) Bumps [actions/cache](https://github.com/actions/cache) from 2.1.6 to 2.1.7. - [Release notes](https://github.com/actions/cache/releases) - [Commits](actions/cache@v2.1.6...v2.1.7) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: RPC tests fail if FeeMarket `BaseFee` is enabled by default (#770) * Fix(FeeMarket): Enable FeeMarkat BaseFee * fix rpc tests * changelog Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Freddy Caceres <freddy.caceres@crypto.com> Co-authored-by: Federico Kunze Küllmer <federico.kunze94@gmail.com> * changelog Co-authored-by: Daniel Burckhardt <daniel.m.burckhardt@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Freddy Caceres <freddy.caceres@crypto.com> * changelog `v0.8.1` (#805) * release: `v0.8.0` changelog (#757) * release: v0.8.1 changes (#775) * docs: update changelog (#765) * feemarket: unit tests EIP1559 (#758) * Fee-Market(Types): Setup Params tests * Fee-Market(Types): Add all Params tests * Fee-Market(Types): Add genesis tests * Fee-Market(Keeper): Copy Keeper setup from EVM module and add Params tests * Fee-Market(Keeper): Add Keeper tests * Fee-Market(Keeper): Add review comments * Fee-Market(Keeper): WIP grpc tests * Fee-Market(Keeper): WIP ERIP1559 tests * Fee-Market(Keeper): WIP ERIP1559 tests * Fee-Market(Keeper): WIP ERIP1559 tests maxGas influences on baseFee * Fee-Market(Keeper): Add last ERIP1559 tests * Fee-Market(Keeper): Add abci tests * rpc: fix default signer (#769) * rpc: fix default signer * changelog * build(deps): bump actions/cache from 2.1.6 to 2.1.7 (#772) Bumps [actions/cache](https://github.com/actions/cache) from 2.1.6 to 2.1.7. - [Release notes](https://github.com/actions/cache/releases) - [Commits](actions/cache@v2.1.6...v2.1.7) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: RPC tests fail if FeeMarket `BaseFee` is enabled by default (#770) * Fix(FeeMarket): Enable FeeMarkat BaseFee * fix rpc tests * changelog Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Freddy Caceres <freddy.caceres@crypto.com> Co-authored-by: Federico Kunze Küllmer <federico.kunze94@gmail.com> * changelog Co-authored-by: Daniel Burckhardt <daniel.m.burckhardt@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Freddy Caceres <freddy.caceres@crypto.com> * changelog Co-authored-by: Daniel Burckhardt <daniel.m.burckhardt@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Freddy Caceres <freddy.caceres@crypto.com> * changelog Co-authored-by: Daniel Burckhardt <daniel.m.burckhardt@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Freddy Caceres <freddy.caceres@crypto.com> * docs: backport changelog updates * unreleased Co-authored-by: Daniel Burckhardt <daniel.m.burckhardt@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Freddy Caceres <freddy.caceres@crypto.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: ENG-273 RPC tests are failing if FeeMarket Base Fee is enabled by default
Description
This PR enables the FeeMarket
BaseFeeby default and fixes the failing rpc tests by replacing the hardcodedgasPrice