This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
improve error message in SendTransaction json-rpc api
#786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihuang
requested review from
fedekunze,
jolube and
khoslaventures
as code owners
yihuang
changed the title
SendTransaction json-rpc apiSendTransaction json-rpc api
Codecov Report
@@ Coverage Diff @@
## main #786 +/- ##
==========================================
- Coverage 57.45% 57.30% -0.16%
==========================================
Files 71 71
Lines 6107 6041 -66
==========================================
- Hits 3509 3462 -47
+ Misses 2396 2377 -19
Partials 202 202
|
| if err == nil { | ||
| err = errors.New(rsp.RawLog) | ||
| } | ||
| if rsp != nil && rsp.Code != 0 { |
There was a problem hiding this comment.
yes, it try to recover error from rsp if rsp.Code != 0.
| if err == nil { | ||
| err = errors.New(rsp.RawLog) | ||
| } | ||
| if rsp != nil && rsp.Code != 0 { |
There was a problem hiding this comment.
x/evm/keeper/utils.go
Outdated
| @@ -28,7 +27,7 @@ func (k Keeper) DeductTxCostsFromUserBalance( | |||
| // fetch sender account from signature | |||
| signerAcc, err := authante.GetSignerAcc(ctx, k.accountKeeper, msgEthTx.GetFrom()) | |||
| if err != nil { | |||
| return nil, stacktrace.Propagate(err, "account not found for sender %s", msgEthTx.From) | |||
| return nil, err | |||
There was a problem hiding this comment.
how about adding additional info
account not found for sender..
There was a problem hiding this comment.
yeah, kept original error message with sdkerrors.Wrapf.
x/evm/keeper/utils.go
Outdated
| "failed to deduct full gas cost %s from the user %s balance", | ||
| fees, msgEthTx.From, | ||
| ) | ||
| return nil, err |
There was a problem hiding this comment.
adding addtional info
failed to deduct full gas cost %s from the user %s balance
There was a problem hiding this comment.
kept original error message with sdkerrors.Wrapf.
yihuang
force-pushed
the
error-message
branch
from
94b52e8
to
ad87657
Compare
Closes: evmos#785 Solution: - Remove `stacktrace.Propagate`s, and recover error message in jsonrpc server changelog fix error messages
yihuang
force-pushed
the
error-message
branch
from
ad87657
to
77af78b
Compare
fedekunze
added
backport/0.16.x
mergify bot
pushed a commit
that referenced
this pull request
Nov 26, 2021
* fix error message in `SendTransaction` json-rpc api Closes: #785 Solution: - Remove `stacktrace.Propagate`s, and recover error message in jsonrpc server changelog fix error messages * Update x/evm/keeper/msg_server.go Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> (cherry picked from commit c8d4d3f) # Conflicts: # CHANGELOG.md
mergify bot
pushed a commit
that referenced
this pull request
Nov 26, 2021
* fix error message in `SendTransaction` json-rpc api Closes: #785 Solution: - Remove `stacktrace.Propagate`s, and recover error message in jsonrpc server changelog fix error messages * Update x/evm/keeper/msg_server.go Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> (cherry picked from commit c8d4d3f) # Conflicts: # CHANGELOG.md # app/ante/eth.go # go.mod # rpc/ethereum/namespaces/eth/api.go # x/evm/keeper/keeper.go # x/evm/keeper/state_transition.go
thomas-nguy
referenced
this pull request
in crypto-org-chain/ethermint
Nov 29, 2021
thomas-nguy
referenced
this pull request
in crypto-org-chain/ethermint
Nov 29, 2021
leejw51crypto
pushed a commit
to leejw51crypto/ethermint
that referenced
this pull request
Nov 30, 2021
* fix error message in `SendTransaction` json-rpc api Closes: evmos#785 Solution: - Remove `stacktrace.Propagate`s, and recover error message in jsonrpc server changelog fix error messages * Update x/evm/keeper/msg_server.go Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #785
Solution:
sdkerrors.Wrap,since cosmos-sdk already support extract stacktrace in debug mode.
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)