This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
x/evm/types: properly split in 32 chunks trace.Memory #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedekunze
approved these changes
Dec 15, 2021
This change fixes an insidious bug that unfortunately tried to split values in multiples of 32, but unfortunately due to the loop conditions, if the length of trace.Memory was less than 32, nothing would be added; if the value wasn't a multiple of 32, the ends wouldn't be added in. Fixes #837
odeke-em
force-pushed
the
x-evm-types-fix-32-splitting-code
branch
from
823b7ba
to
39f0844
Compare
Done, and thank you @fedekunze! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes an insidious bug that unfortunately
tried to split values in multiples of 32, but unfortunately
due to the loop conditions, if the length of trace.Memory
was less than 32, nothing would be added; if the value wasn't
a multiple of 32, the ends wouldn't be added in.
Fixes #837