Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Add configurable timeouts to http server #979

Merged
merged 4 commits into from
Mar 9, 2022
Merged

Conversation

yihuang
Copy link
Contributor

@yihuang yihuang commented Mar 8, 2022

Description

Closes: #963

not tested yet.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #979 (d2dde0a) into main (67fba0a) will decrease coverage by 0.05%.
The diff coverage is 40.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #979      +/-   ##
==========================================
- Coverage   59.09%   59.03%   -0.06%     
==========================================
  Files          79       79              
  Lines        6508     6518      +10     
==========================================
+ Hits         3846     3848       +2     
- Misses       2444     2452       +8     
  Partials      218      218              
Impacted Files Coverage Δ
server/config/config.go 20.98% <40.62%> (-0.07%) ⬇️

Copy link
Contributor

@crypto-facs crypto-facs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, I'd also add a test so that we ensure that the toml is correctly parsed to the config

server/config/toml.go Show resolved Hide resolved
@fedekunze fedekunze merged commit dbe9f70 into evmos:main Mar 9, 2022
@yihuang yihuang deleted the timeouts branch March 9, 2022 07:49
yihuang added a commit to yihuang/ethermint that referenced this pull request Mar 24, 2022
* Add configurable timeouts to http server

Closes: evmos#963

* add flags

* changelog

* fix toml
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use timeout for heavy rpc handler
3 participants