Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v9.1.0 #1011

Merged
merged 3 commits into from
Oct 25, 2022
Merged

Release v9.1.0 #1011

merged 3 commits into from
Oct 25, 2022

Conversation

facs95
Copy link
Contributor

@facs95 facs95 commented Oct 25, 2022

Description

credits -> @ramacarlucho

Added a CacheContext as suggested by @fedekunze to the upgrade handler so that refund is only committed to the store if all refunds are successful. Also extended tests for more coverage.

Updated SDK version to v0.45.10.

Closes: #XXX


All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

PR review checkboxes:

I have...

  • added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • included the correct type prefix in the PR title
  • targeted the correct branch (see PR Targeting)
  • provided a link in the PR description to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all required CI checks have passed

Code maintenance:

I have...

  • written unit and integration tests
  • added relevant godoc and code comments.
  • updated relevant documentation (docs/) or specification (x/<module>/spec/)

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • confirmed that this PR does not change production code

@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Merging #1011 (d3746f5) into release/v9.x.x (db076d7) will decrease coverage by 0.01%.
The diff coverage is 79.36%.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release/v9.x.x    #1011      +/-   ##
==================================================
- Coverage           80.72%   80.71%   -0.02%     
==================================================
  Files                 128      129       +1     
  Lines                7346     7409      +63     
==================================================
+ Hits                 5930     5980      +50     
- Misses               1268     1279      +11     
- Partials              148      150       +2     
Impacted Files Coverage Δ
app/upgrades/v9_1/upgrades.go 77.35% <77.35%> (ø)
app/app.go 84.42% <90.00%> (+0.07%) ⬆️

Copy link
Contributor

@danburck danburck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @facs95
Left a nit comment

app/upgrades/v9_1/upgrades_test.go Show resolved Hide resolved
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Please add a changelog entry

@facs95 facs95 merged commit 80c38f6 into release/v9.x.x Oct 25, 2022
@facs95 facs95 deleted the facs95/v9.1.0 branch October 25, 2022 20:04
facs95 added a commit that referenced this pull request Oct 26, 2022
* update cosmos sdk

* add v9.1.0 upgrade handler and test

* add changelog

Co-authored-by: Ramiro Carlucho <ramirocarlucho@gmail.com>
fedekunze added a commit that referenced this pull request Oct 27, 2022
* v9.0.0 release (#987)

* fix ClawbackEmptyAccounts logic (#951)

* fix ClawbackEmptyAccounts logic

* fix tests

* update changelog

* fix claim_test

* turn dust into a variable

* add module account test

* update test name

* update module account test

* update documentation

* format comment

* update changelog

* Upgrade handler v9 (#952)

* Apply suggestions from code review

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

* use sdk.Int instead of sdkmath.Int

* apply suggestions from review

* fix: adjust clawback fix to sdk v0.45

* check if recover is positive

* Update app/upgrades/v9/upgrades.go

Co-authored-by: Daniel Burckhardt <daniel.m.burckhardt@gmail.com>

* Update app/upgrades/v9/upgrades_test.go

Co-authored-by: Daniel Burckhardt <daniel.m.burckhardt@gmail.com>

* Update app/upgrades/v9/upgrades_test.go

Co-authored-by: Daniel Burckhardt <daniel.m.burckhardt@gmail.com>

* add necessary comments

* remove upgrade height constant

* wrap ReturnFundsFromCommunityPoolToAccount error

* run gofmt

* unwrapping error

* add attestation accounts

* Update CHANGELOG.md

* add accounts comments

Co-authored-by: Ramiro Carlucho <ramirocarlucho@gmail.com>
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Daniel Burckhardt <daniel.m.burckhardt@gmail.com>

* Release v9.1.0 (#1011)

* update cosmos sdk

* add v9.1.0 upgrade handler and test

* add changelog

Co-authored-by: Ramiro Carlucho <ramirocarlucho@gmail.com>

* fix linter

Co-authored-by: Ramiro Carlucho <ramirocarlucho@gmail.com>
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Daniel Burckhardt <daniel.m.burckhardt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants