-
Notifications
You must be signed in to change notification settings - Fork 838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v9.1.0 #1011
Release v9.1.0 #1011
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release/v9.x.x #1011 +/- ##
==================================================
- Coverage 80.72% 80.71% -0.02%
==================================================
Files 128 129 +1
Lines 7346 7409 +63
==================================================
+ Hits 5930 5980 +50
- Misses 1268 1279 +11
- Partials 148 150 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @facs95
Left a nit comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK. Please add a changelog entry
* update cosmos sdk * add v9.1.0 upgrade handler and test * add changelog Co-authored-by: Ramiro Carlucho <ramirocarlucho@gmail.com>
* v9.0.0 release (#987) * fix ClawbackEmptyAccounts logic (#951) * fix ClawbackEmptyAccounts logic * fix tests * update changelog * fix claim_test * turn dust into a variable * add module account test * update test name * update module account test * update documentation * format comment * update changelog * Upgrade handler v9 (#952) * Apply suggestions from code review Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> * use sdk.Int instead of sdkmath.Int * apply suggestions from review * fix: adjust clawback fix to sdk v0.45 * check if recover is positive * Update app/upgrades/v9/upgrades.go Co-authored-by: Daniel Burckhardt <daniel.m.burckhardt@gmail.com> * Update app/upgrades/v9/upgrades_test.go Co-authored-by: Daniel Burckhardt <daniel.m.burckhardt@gmail.com> * Update app/upgrades/v9/upgrades_test.go Co-authored-by: Daniel Burckhardt <daniel.m.burckhardt@gmail.com> * add necessary comments * remove upgrade height constant * wrap ReturnFundsFromCommunityPoolToAccount error * run gofmt * unwrapping error * add attestation accounts * Update CHANGELOG.md * add accounts comments Co-authored-by: Ramiro Carlucho <ramirocarlucho@gmail.com> Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Daniel Burckhardt <daniel.m.burckhardt@gmail.com> * Release v9.1.0 (#1011) * update cosmos sdk * add v9.1.0 upgrade handler and test * add changelog Co-authored-by: Ramiro Carlucho <ramirocarlucho@gmail.com> * fix linter Co-authored-by: Ramiro Carlucho <ramirocarlucho@gmail.com> Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Daniel Burckhardt <daniel.m.burckhardt@gmail.com>
Description
credits -> @ramacarlucho
Added a CacheContext as suggested by @fedekunze to the upgrade handler so that refund is only committed to the store if all refunds are successful. Also extended tests for more coverage.
Updated SDK version to v0.45.10.
Closes: #XXX
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
PR review checkboxes:
I have...
Unreleased
section inCHANGELOG.md
Code maintenance:
I have...
godoc
and code comments.docs/
) or specification (x/<module>/spec/
)Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.
I have...