Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): apply google CLI Syntax for required and optional args #1027

Merged
merged 4 commits into from
Nov 1, 2022

Conversation

GAtom22
Copy link
Contributor

@GAtom22 GAtom22 commented Oct 31, 2022

Description

Apply Google CLI Syntax for required and optional args

Closes: ENG-832


All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

PR review checkboxes:

I have...

  • added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • included the correct type prefix in the PR title
  • targeted the correct branch (see PR Targeting)
  • provided a link in the PR description to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all required CI checks have passed

Code maintenance:

I have...

  • written unit and integration tests
  • added relevant godoc and code comments.
  • updated relevant documentation (docs/) or specification (x/<module>/spec/)

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • confirmed that this PR does not change production code

@github-actions github-actions bot added the CLI label Oct 31, 2022
@github-actions github-actions bot added the docs label Oct 31, 2022
@GAtom22 GAtom22 marked this pull request as ready for review October 31, 2022 14:08
@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Merging #1027 (780296d) into main (ccfe777) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 780296d differs from pull request most recent head a259517. Consider uploading reports for the commit a259517 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1027   +/-   ##
=======================================
  Coverage   77.36%   77.36%           
=======================================
  Files         129      129           
  Lines        7546     7546           
=======================================
  Hits         5838     5838           
  Misses       1562     1562           
  Partials      146      146           
Impacted Files Coverage Δ
x/erc20/client/cli/query.go 0.00% <0.00%> (ø)

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fedekunze fedekunze enabled auto-merge (squash) October 31, 2022 14:40
@GAtom22 GAtom22 disabled auto-merge October 31, 2022 17:26
@GAtom22 GAtom22 enabled auto-merge (squash) October 31, 2022 17:26
@GAtom22 GAtom22 merged commit 6e63706 into main Nov 1, 2022
@GAtom22 GAtom22 deleted the GAtom22/google-cli-syntax branch November 1, 2022 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants