chore(inflation): Deprecate x/params usage in x/inflation

[Vvaradinov]

Description

Deprecate the usage of the now legacy Cosmos SDK params module within x/inflation.

As of 0.47.0 The Cosmos SDK x/params module has been deprecated in favor of each module housing and providing way to modify their parameters. Each module that has parameters that are changeable during runtime have an authority, the authority can be a module or user account. The Cosmos-SDK team recommends migrating modules away from using the param module. An example of how this could look like can be found cosmos/cosmos-sdk#12363.

Closes: ENG-1076, ENG-582

---

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

PR review checkboxes:

I have...

• added a relevant changelog entry to the Unreleased section in CHANGELOG.md
• included the correct type prefix in the PR title
• targeted the correct branch (see PR Targeting)
• provided a link in the PR description to the relevant issue or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all required CI checks have passed

Code maintenance:

I have...

• written unit and integration tests
• added relevant godoc and code comments.
• updated relevant documentation (docs/) or specification (x/<module>/spec/)

---

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed all author checklist items have been addressed
• confirmed that this PR does not change production code

[linear]

ENG-1076 Deprecate Cosmos x/params logic from Inflation module

In relation to ENG-965

ENG-582 Fix inflation params

Current

Inflation params are not defines as the expected convention:

	ParamStoreKeyMintDenom              = []byte("ParamStoreKeyMintDenom")
	ParamStoreKeyExponentialCalculation = []byte("ParamStoreKeyExponentialCalculation")
	ParamStoreKeyInflationDistribution  = []byte("ParamStoreKeyInflationDistribution")
	ParamStoreKeyEnableInflation        = []byte("ParamStoreKeyEnableInflation")

Expected

Inflation params should be

	ParamStoreKeyMintDenom              = []byte("MintDenom")
	ParamStoreKeyExponentialCalculation = []byte("ExponentialCalculation")
	ParamStoreKeyInflationDistribution  = []byte("InflationDistribution")
	ParamStoreKeyEnableInflation        = []byte("EnableInflation")

Notes

This change requires a store migration

[GAtom22]

Awesome work Vlad! Left a few comments and questions

[MalteHerrmann]

tACK! Two minor comments

[fedekunze]

Thanks @Vvaradinov, the parameter change proposal passes, it should also update the inflation rate

EDIT: let's coordinate about those changes with @danburck

[codecov]

Codecov Report

Merging #1107 (1be6c8f) into main (71ee45d) will decrease coverage by 0.19%.
The diff coverage is 64.86%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1107      +/-   ##
==========================================
- Coverage   77.02%   76.82%   -0.20%     
==========================================
  Files         146      149       +3     
  Lines        8022     8061      +39     
==========================================
+ Hits         6179     6193      +14     
- Misses       1662     1682      +20     
- Partials      181      186       +5     

Impacted Files	Coverage Δ
x/inflation/keeper/keeper.go	77.77% <33.33%> (-11.70%)	⬇️
x/inflation/types/codec.go	41.66% <41.66%> (+41.66%)	⬆️
x/inflation/types/msg.go	50.00% <50.00%> (ø)
x/inflation/keeper/params.go	64.70% <60.00%> (-35.30%)	⬇️
x/inflation/keeper/msg_server.go	66.66% <66.66%> (ø)
x/inflation/migrations/v2/migrate.go	78.57% <78.57%> (ø)
app/app.go	81.81% <100.00%> (ø)
x/inflation/keeper/migrations.go	100.00% <100.00%> (ø)
x/inflation/types/params.go	86.51% <100.00%> (-2.38%)	⬇️