-
Notifications
You must be signed in to change notification settings - Fork 838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(claims) - Depreacte usage of x/params in x/claims #1125
Conversation
ENG-1113 Deprecate Cosmos x/params logic from claims
In relation to ENG-965
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work Vlad! LGTM! Left a few comments
Co-authored-by: Tomas Guerra <54514587+GAtom22@users.noreply.github.com>
…m/evmos/evmos into Vvaradinov/claims-params-refactor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK!
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1125 +/- ##
==========================================
- Coverage 78.09% 77.76% -0.33%
==========================================
Files 133 137 +4
Lines 7856 7890 +34
==========================================
+ Hits 6135 6136 +1
- Misses 1562 1587 +25
- Partials 159 167 +8
|
Deprecates the now legacy Cosmos SDK
x/params
usage inx/claims
module. For more info regarding changes check out evmos/ethermint#1472Closes: ENG-1113
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
PR review checkboxes:
I have...
Unreleased
section inCHANGELOG.md
Code maintenance:
I have...
godoc
and code comments.docs/
) or specification (x/<module>/spec/
)Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.
I have...