Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(revenue) - Migrate Event emitting to TypedEvent #1153

Merged
merged 9 commits into from
Dec 20, 2022

Conversation

Vvaradinov
Copy link
Contributor

Description

Migrate the usage of now deprecated EmitEvent to EmitTypedEvent. New events.proto is created describing each event type the revenue module emits.

Closes: ENG-1172


All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

PR review checkboxes:

I have...

  • added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • included the correct type prefix in the PR title
  • targeted the correct branch (see PR Targeting)
  • provided a link in the PR description to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all required CI checks have passed

Code maintenance:

I have...

  • written unit and integration tests
  • added relevant godoc and code comments.
  • updated relevant documentation (docs/) or specification (x/<module>/spec/)

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • confirmed that this PR does not change production code

@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #1153 (892ccc9) into main (d060fa7) will increase coverage by 0.01%.
The diff coverage is 63.63%.

❗ Current head 892ccc9 differs from pull request most recent head 087f375. Consider uploading reports for the commit 087f375 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1153      +/-   ##
==========================================
+ Coverage   76.52%   76.53%   +0.01%     
==========================================
  Files         149      149              
  Lines        8110     8105       -5     
==========================================
- Hits         6206     6203       -3     
+ Misses       1708     1706       -2     
  Partials      196      196              
Impacted Files Coverage Δ
x/revenue/keeper/msg_server.go 93.96% <60.86%> (-4.59%) ⬇️
x/revenue/keeper/evm_hooks.go 94.23% <70.00%> (-5.77%) ⬇️
x/erc20/proposal_handler.go 1.69% <0.00%> (+0.05%) ⬆️
x/erc20/keeper/msg_server.go 97.56% <0.00%> (+3.37%) ⬆️

x/revenue/keeper/msg_server.go Show resolved Hide resolved
x/revenue/types/events.go Outdated Show resolved Hide resolved
x/revenue/keeper/evm_hooks.go Outdated Show resolved Hide resolved
Copy link
Contributor

@ramacarlucho ramacarlucho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix linter issues?

Copy link
Contributor

@GAtom22 GAtom22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @Vvaradinov!! Left a couple of comments

proto/evmos/revenue/v1/events.proto Outdated Show resolved Hide resolved
x/revenue/keeper/msg_server.go Outdated Show resolved Hide resolved
Vvaradinov and others added 2 commits December 12, 2022 16:31
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, minor change required

proto/evmos/revenue/v1/events.proto Show resolved Hide resolved
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Let's look into the fields types in a separate PR

@Vvaradinov Vvaradinov enabled auto-merge (squash) December 20, 2022 09:02
@Vvaradinov Vvaradinov merged commit 6a55ad2 into main Dec 20, 2022
@Vvaradinov Vvaradinov deleted the Vvaradinov/revenue-migrate-typed-events branch December 20, 2022 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants