Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix docker-build command #116

Merged
merged 2 commits into from
Nov 25, 2021
Merged

build: fix docker-build command #116

merged 2 commits into from
Nov 25, 2021

Conversation

prajjwol
Copy link
Contributor

@prajjwol prajjwol commented Nov 24, 2021 •
edited

Closes: #ENG-58

Description

  • Fixes build-docker command where the latest image created is tharsis/evmos:COMMIT_SHA

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@linear
Copy link

linear bot commented Nov 24, 2021

ENG-58 Create a docker image for testnet

Action Items:

Notes: Based on Gaiadnode should be fine

@github-actions github-actions bot added the build label Nov 24, 2021
fedekunze
fedekunze reviewed Nov 24, 2021
View reviewed changes
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK. Can you also update the installation docs (docs/quickstart/installation.md) and add a Bug Fix Changelog entry?

@prajjwol
Copy link
Contributor Author

utACK. Can you also update the installation docs (docs/quickstart/installation.md) and add a Bug Fix Changelog entry?

will do!

@fedekunze fedekunze added the backport/3.0.x PR scheduled for inclusion in the v3.0's next stable release label Nov 25, 2021
@prajjwol prajjwol force-pushed the prajjwol/eng-58-create_docker_image branch from 6ec60a3 to 42907ac Compare November 25, 2021 17:53
@github-actions github-actions bot added the docs label Nov 25, 2021
@prajjwol prajjwol force-pushed the prajjwol/eng-58-create_docker_image branch from 42907ac to 5ad8b83 Compare November 25, 2021 18:37
fedekunze
fedekunze approved these changes Nov 25, 2021
View reviewed changes
docs/quickstart/installation.md Outdated Show resolved Hide resolved
@fedekunze fedekunze enabled auto-merge (squash) November 25, 2021 18:39
@fedekunze fedekunze merged commit 0effbfa into main Nov 25, 2021
@fedekunze fedekunze deleted the prajjwol/eng-58-create_docker_image branch November 25, 2021 18:41
faddat referenced this pull request in notional-labs/evmos Dec 9, 2021
@fedekunze
build: deploy docs to GitHub Pages (#116)
f762087 
* build: deploy docs to GitHub Pages

* versioning

* try fix

* fix swagger docs

* fix docs build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedekunze fedekunze fedekunze approved these changes

@jolube jolube Awaiting requested review from jolube

@khoslaventures khoslaventures Awaiting requested review from khoslaventures

Assignees
No one assigned
Labels
backport/3.0.x PR scheduled for inclusion in the v3.0's next stable release build docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@prajjwol @fedekunze