New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
init commit for bump ibc-go to v6.1.0 #1196
Conversation
Getting this merge-ready depends on merging this PR in ethermint: |
@sontrinh16 looks good, thanks! Is there anything left to address to mark it R4R? |
i think i'm just wait for a ethermint release that use ibc-go v6 to run all the unit test for evmos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @sontrinh16 , looks great! could you take a look at this again now that ethermint has been bumped to ibc v6? looks like there are some issues with the unit tests when I ran them. If you're too busy, would be great if I could get access to the branch to finish it up for you.
oh sweet gonna doing now, i was just fixing test for a forked ibc 6 ethermint and running on some same proto err evmos have on ethermint |
…into bump_ibc_v6
@fedekunze, i think it's ready for review now |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1196 +/- ##
==========================================
- Coverage 76.45% 76.19% -0.26%
==========================================
Files 149 149
Lines 8238 8280 +42
==========================================
+ Hits 6298 6309 +11
- Misses 1749 1779 +30
- Partials 191 192 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The replace
of Ethermint in go.mod breaks our upgrade tests (make test-upgrade
), please revise. I think the reason are problems we still have on Ethermint with the recent changes to how parameters are stored.
We shouldn't merge it in this context IMO
10:20AM INF migrating module evm from version 3 to version 4
panic: parameter EVMDenom not registered
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!. I'll follow up with another PR replacing Ethermint with our own and fixing the upgrade tests.
@Vvaradinov will address the tests in a separate PR
Description
Bump ibc-go version to v6.1.0
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
PR review checkboxes: