Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(inflation): run migration to delete EpochMintProvision from the store #1210

Merged
merged 8 commits into from Jan 5, 2023

Conversation

Vvaradinov
Copy link
Contributor

Description

Closes: ENG-1270


All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

PR review checkboxes:

I have...

  • added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • included the correct type prefix in the PR title
  • targeted the correct branch (see PR Targeting)
  • provided a link in the PR description to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all required CI checks have passed

Code maintenance:

I have...

  • written unit and integration tests
  • added relevant godoc and code comments.
  • updated relevant documentation (docs/) or specification (x/<module>/spec/)

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • confirmed that this PR does not change production code

@linear
Copy link

linear bot commented Jan 5, 2023

@Vvaradinov Vvaradinov changed the title chore: run migration to delete EpochMintProvision from the store chore(inflation): run migration to delete EpochMintProvision from the store Jan 5, 2023
@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Merging #1210 (a183e20) into main (e4da9cb) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head a183e20 differs from pull request most recent head 0938737. Consider uploading reports for the commit 0938737 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1210      +/-   ##
==========================================
+ Coverage   76.41%   76.42%   +0.01%     
==========================================
  Files         148      149       +1     
  Lines        8073     8078       +5     
==========================================
+ Hits         6169     6174       +5     
  Misses       1708     1708              
  Partials      196      196              
Impacted Files Coverage Δ
x/inflation/keeper/migrations.go 100.00% <100.00%> (ø)
x/inflation/migrations/v3/migrate.go 100.00% <100.00%> (ø)

@Vvaradinov Vvaradinov marked this pull request as ready for review January 5, 2023 09:26
@Vvaradinov Vvaradinov requested review from ramacarlucho and a team as code owners January 5, 2023 09:26
@Vvaradinov Vvaradinov requested review from danburck, fedekunze and 4rgon4ut and removed request for a team January 5, 2023 09:26
Copy link
Contributor

@4rgon4ut 4rgon4ut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good job @Vvaradinov

@fedekunze fedekunze enabled auto-merge (squash) January 5, 2023 16:08
@fedekunze fedekunze merged commit edf87ce into main Jan 5, 2023
@fedekunze fedekunze deleted the Vvaradinov/store-migration-epochmintprovision branch January 5, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants