fix(ante): use DynamicFeeChecker for Cosmos txs #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedekunze
requested review from
Vvaradinov and
GAtom22
and removed request for
a team
facs95
approved these changes
Jan 22, 2023
0a1c
reviewed
Jan 22, 2023
ENG-1436 Use DynamicFeeChecker for Cosmos txs
Currently we're using the default fee checker on the Scope of work:
|
* chore(tests): fix erc20 tests * chore(tests): fix recovery keeper tests * chore(tests): fix revenue keeper tests * chore(tests): fix claims keeper tests * chore(tests): fix claims ibc tests * chore(tests): fix lint issues * chore(tests): add tx fees check * chore(tests): small refactor on recovery ibc tests * chore(tests): use BaseDenom * chore(tests): fix lint issues
0a1c
reviewed
Jan 31, 2023
| } | ||
| if options.SignModeHandler == nil { | ||
| return errorsmod.Wrap(errortypes.ErrLogic, "sign mode handler is required for AnteHandler") | ||
| } |
There was a problem hiding this comment.
We should add TxFeeChecker too, to avoid unexpected behavior.
| @@ -0,0 +1,596 @@ | |||
| package ibctesting | |||
There was a problem hiding this comment.
Why is IBC testing infrastructure needed for this, exactly?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes https://linear.app/evmos/issue/ENG-1436/use-dynamicfeechecker-for-cosmos-txs