Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(evm): remove vm package #1355

Merged
merged 3 commits into from
Feb 7, 2023
Merged

chore(evm): remove vm package #1355

merged 3 commits into from
Feb 7, 2023

Conversation

fedekunze
Copy link
Contributor

@fedekunze fedekunze commented Feb 6, 2023

Description


Closes ENG-1450

@fedekunze fedekunze marked this pull request as ready for review February 6, 2023 21:06
@fedekunze fedekunze requested a review from a team as a code owner February 6, 2023 21:06
@fedekunze fedekunze requested review from 0a1c and ramacarlucho and removed request for a team February 6, 2023 21:06
@evmos evmos deleted a comment from linear bot Feb 6, 2023
@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Merging #1355 (34a875e) into main (185e74c) will decrease coverage by 0.01%.
The diff coverage is 57.14%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1355      +/-   ##
==========================================
- Coverage   71.59%   71.58%   -0.01%     
==========================================
  Files         256      256              
  Lines       17506    17504       -2     
==========================================
- Hits        12533    12531       -2     
  Misses       4417     4417              
  Partials      556      556              
Impacted Files Coverage Δ
app/ante/ante.go 6.00% <0.00%> (ø)
app/ante/evm/fee_market.go 76.92% <ø> (ø)
app/ante/handler_options.go 33.33% <0.00%> (ø)
app/ante/evm/setup.go 15.65% <33.33%> (ø)
app/ante/evm/fees.go 56.04% <50.00%> (ø)
app/ante/cosmos/min_price.go 100.00% <100.00%> (ø)
app/ante/evm/eth.go 80.17% <100.00%> (ø)
app/ante/evm/fee_checker.go 96.77% <100.00%> (ø)
app/ante/evm/sigverify.go 100.00% <100.00%> (ø)
app/app.go 82.09% <100.00%> (ø)
... and 2 more

Copy link
Contributor

@facs95 facs95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the code quality perspective I would rather have a bit more duplicate code for less dependencies within packages - referring to the interfaces but I am ok with this if this is the decided way to go. Otherwise everything else looks good to me.

Copy link
Contributor

@0a1c 0a1c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

x/evm/keeper/state_transition.go Show resolved Hide resolved
@fedekunze fedekunze merged commit 0fff6e4 into main Feb 7, 2023
@fedekunze fedekunze deleted the fedekunze/vm branch February 7, 2023 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants