-
Notifications
You must be signed in to change notification settings - Fork 838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
imp (claims): validate authorized channels in message to update claims params #1378
Conversation
ENG-1400 Stateful Validation of claims params against stored values
Claim params values are not currently verified when using Scope of Work
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1378 +/- ##
==========================================
+ Coverage 72.23% 72.27% +0.04%
==========================================
Files 259 259
Lines 17614 17640 +26
==========================================
+ Hits 12724 12750 +26
Misses 4321 4321
Partials 569 569
|
…channels looking for the channel ID
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MalteHerrmann! left some minor comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK, pending bug fix entry
@MalteHerrmann can you look into the tests and linter errors? |
Description
This PR adds the validation of the authorized channels in a
MsgUpdateParams
before applying the changes.It iterates through the available channels in
app.ibcKeeper.ChannelKeeper
and checks if the channels are present there.Closes ENG-1400