chore(test): prepare test files for refactor #1391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedekunze
requested review from
ramacarlucho,
hanchon and
a team
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1391 +/- ##
=======================================
Coverage 72.42% 72.42%
=======================================
Files 259 260 +1
Lines 17684 17685 +1
=======================================
+ Hits 12807 12808 +1
Misses 4308 4308
Partials 569 569
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
GAtom22
reviewed
Feb 14, 2023
|
Lint is failing |
MalteHerrmann
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactors the current test in preparation for the testing refactor. The new structure is as follows:
keeper_test.go: should only contain tests on thekeeper.gosetup_test.go: setup of the testing suitesutils_test.go: all utils functions that are duplicated and that will need to be removed in follow-up PRs