chore (tests): move utilities from tests folder to testutil package

[MalteHerrmann]

Description

Going along with the current restructuring of the way we are handling tests, this PR moves the utility functions in tests/signer.go to testutil/signer.go.

This way, the tests folder only contains concrete meta-testing suites like the ledger integration tests on the Evmos side as well as the E2E tests and all utility functions are contained in the testutil folder.

Other than that, this PR

• fixes the use of the context's chain id in the app/ante/... test files, that was accidentally removed when fixing merge conflicts on a prior PR.
• fixes import cycles after moving the utilities from the tests folder, because the testutil package imports several types packages, which then use the testutils for testing

[MalteHerrmann]

currently running into import cycles with several tests after this refactor, but I still think it's much cleaner this way - currently fixing those

[facs95]

I know this PR is not ready but as I see the progress and I am trying to reorganize this as well - I wanted to open the discussion about the directories you are trying to use.

I agree with the architecture proposed in this ticket https://linear.app/evmos/issue/ENG-1502/evmos-testing-setup in which the utils package for the new common testing refractor is under test/util .

I think that would make more sense than maintaining a ./testutil package and directory. Would be cleaner imo to have everything under test/ but well organized, similar to the description in the ticket

[MalteHerrmann]

@facs95 I would actually more be a proponent of keeping the utilities and the actual tests separate just to keep everything clean. The ./tests folder contains the Evmos side of the Ledger integration tests as well as upgrade tests. Having a clear directory for reusable code like ./testutil would IMO also be a good thing for the Evmos SDK just so people don't get confused when navigating the folders. But def. open to discussions about this!

The work to be done here in terms of having the import cycles solved must be done in either of those two options, so I'll continue with this for now ✌️

[codecov]

Codecov Report

Merging #1393 (d4da6d1) into main (c667044) will not change coverage.
The diff coverage is 85.71%.

❗ Current head d4da6d1 differs from pull request most recent head 4f1f521. Consider uploading reports for the commit 4f1f521 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1393   +/-   ##
=======================================
  Coverage   72.42%   72.42%           
=======================================
  Files         260      260           
  Lines       17685    17685           
=======================================
  Hits        12808    12808           
  Misses       4308     4308           
  Partials      569      569           

Impacted Files	Coverage Δ
x/erc20/types/params.go	85.71% <66.66%> (ø)
x/evm/types/dynamic_fee_tx.go	90.37% <100.00%> (ø)
x/evm/types/legacy_tx.go	91.72% <100.00%> (ø)
x/evm/types/tx_data.go	97.91% <100.00%> (ø)

[facs95]

Makes sense - I am going to give this an approval not to block other refractos as this separation from the integration tests to the utilities had to be done anyways regardless of the naming. Awesome job solving the cycles!

[facs95]

Can you please add a changelog?

[fedekunze]

ACK pending changelog entry under Improvements