Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ante) refactor to run authz anteHander in deliverTx mode #1403

Merged
merged 2 commits into from
Feb 16, 2023

Conversation

GAtom22
Copy link
Contributor

@GAtom22 GAtom22 commented Feb 16, 2023

@linear
Copy link

linear bot commented Feb 16, 2023

ENG-1512 Run Authz Limiter Decorator on DeliverTx

Currently the AuthzLimiterDecorator only runs during CheckTx. Given that v12 is a breaking release we should remove this line and update the tests to also support DeliverTx

@GAtom22 GAtom22 marked this pull request as ready for review February 16, 2023 17:26
@GAtom22 GAtom22 requested a review from a team as a code owner February 16, 2023 17:26
@GAtom22 GAtom22 requested review from Vvaradinov, MalteHerrmann, fedekunze and facs95 and removed request for a team February 16, 2023 17:26
@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #1403 (e82090f) into main (0af5d31) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1403      +/-   ##
==========================================
- Coverage   72.42%   72.42%   -0.01%     
==========================================
  Files         260      260              
  Lines       17685    17684       -1     
==========================================
- Hits        12808    12807       -1     
  Misses       4308     4308              
  Partials      569      569              
Impacted Files Coverage Δ
app/ante/cosmos/authz.go 86.66% <100.00%> (-0.29%) ⬇️

@fedekunze fedekunze merged commit 592362e into main Feb 16, 2023
@fedekunze fedekunze deleted the GAtom22/update-ante branch February 16, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants