Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(tests) refactor DeployContract func #1408

Merged
merged 23 commits into from
Feb 22, 2023
Merged

chore(tests) refactor DeployContract func #1408

merged 23 commits into from
Feb 22, 2023

Conversation

GAtom22
Copy link
Contributor

@GAtom22 GAtom22 commented Feb 17, 2023

Description

Closes #XXX

@GAtom22 GAtom22 changed the title chore(tests) add DeployContract func to testutil chore(tests) refactor DeployContract func Feb 20, 2023
@GAtom22 GAtom22 marked this pull request as ready for review February 20, 2023 17:22
@GAtom22 GAtom22 requested review from hanchon and a team as code owners February 20, 2023 17:22
@GAtom22 GAtom22 requested review from 0a1c, facs95, fedekunze, MalteHerrmann, Vvaradinov and a team and removed request for a team February 20, 2023 17:22
fedekunze
fedekunze reviewed Feb 21, 2023
View reviewed changes
testutil/contract.go Show resolved Hide resolved
testutil/contract.go Outdated Show resolved Hide resolved
x/revenue/keeper/utils_test.go Outdated Show resolved Hide resolved
x/revenue/keeper/utils_test.go Outdated Show resolved Hide resolved
facs95
facs95 approved these changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@facs95 facs95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Pending changelog

fedekunze
fedekunze approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, pending outstanding comment

fedekunze
fedekunze reviewed Feb 22, 2023
View reviewed changes
testutil/contract.go Outdated Show resolved Hide resolved
testutil/contract.go Outdated Show resolved Hide resolved
testutil/contract.go Outdated Show resolved Hide resolved
testutil/contract.go Outdated Show resolved Hide resolved
GAtom22 and others added 2 commits February 22, 2023 11:12
@GAtom22 @fedekunze
Apply suggestions from code review
1c39f0d 
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
@GAtom22
fix lint issues
157cfa6
@fedekunze fedekunze merged commit acec732 into main Feb 22, 2023
@fedekunze fedekunze deleted the GAtom22/deploy-contract branch February 22, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facs95 facs95 facs95 approved these changes

@hanchon hanchon Awaiting requested review from hanchon

@0a1c 0a1c Awaiting requested review from 0a1c 0a1c is a code owner automatically assigned from evmos/core-engineering

@MalteHerrmann MalteHerrmann Awaiting requested review from MalteHerrmann

@Vvaradinov Vvaradinov Awaiting requested review from Vvaradinov

@fedekunze fedekunze Awaiting requested review from fedekunze

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@GAtom22 @facs95 @fedekunze