-
Notifications
You must be signed in to change notification settings - Fork 833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ante) add block gas limit check for cosmos txs #1435
Conversation
ENG-1563 Tx timeout error
When exceeding block max gas, the CLI returns a tx timeout error:
Steps to reproduce:
To inform the user about this situation, the error message should provide more information rather than the timeout error. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1435 +/- ##
==========================================
+ Coverage 72.70% 72.72% +0.01%
==========================================
Files 265 265
Lines 18209 18219 +10
==========================================
+ Hits 13239 13249 +10
Misses 4380 4380
Partials 590 590
|
Since this decorator is used in all the ante handlers can you remove this check https://github.com/evmos/evmos/blob/main/app/ante/evm/eth.go#L222 ? I dont think its needed anymore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Besides my previous comment
@facs95 But what about this logic? we should set the gasWanted in the tx Gas that is passed over the next decorator, right? |
Description
Closes https://linear.app/evmos/issue/ENG-1563/tx-timeout-error