Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/incentives module #176

Merged
merged 78 commits into from
Jan 13, 2022
Merged

x/incentives module #176

merged 78 commits into from
Jan 13, 2022

Conversation

danburck
Copy link
Contributor

@danburck danburck commented Dec 15, 2021 •
edited
Loading

Description

This PR adds the x/incentives module. It includes:

  • Proposals
  • Allocation
  • Distribution
  • Store participants interaction on KV store with EVM hook
  • Clients(gRPC, CLI)
  • Events
  • Unit tests

A work-in-progress spec can be found here:

@github-actions github-actions bot added the proto label Dec 15, 2021
@github-actions github-actions bot added the docs label Dec 15, 2021
@danburck danburck changed the title Feat(incentives): Add proposal proto Incentives Module Dec 16, 2021
fedekunze
fedekunze reviewed Dec 16, 2021
View reviewed changes
x/incentives/types/errors.go Outdated Show resolved Hide resolved
proto/evmos/incentives/v1/genesis.proto Show resolved Hide resolved
proto/evmos/incentives/v1/incentives.proto Show resolved Hide resolved
fedekunze
fedekunze reviewed Dec 20, 2021
View reviewed changes
x/incentives/keeper/distribution.go Outdated Show resolved Hide resolved
x/incentives/keeper/distribution.go Outdated Show resolved Hide resolved
x/incentives/keeper/distribution.go Outdated Show resolved Hide resolved
x/incentives/keeper/distribution.go Outdated Show resolved Hide resolved
x/incentives/keeper/distribution.go Outdated Show resolved Hide resolved
x/incentives/keeper/distribution.go Show resolved Hide resolved
x/incentives/types/genesis.go Show resolved Hide resolved
x/incentives/types/genesis.go Outdated Show resolved Hide resolved
x/incentives/types/incentive.go Show resolved Hide resolved
danburck
danburck commented Dec 21, 2021
View reviewed changes
x/incentives/types/keys.go Outdated Show resolved Hide resolved
@github-actions github-actions bot added the CLI label Dec 21, 2021
@danburck danburck marked this pull request as ready for review January 11, 2022 08:58
fedekunze
fedekunze reviewed Jan 11, 2022
View reviewed changes
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We can improve performance a lot if we use a map during the allocation iteration

go.mod Outdated Show resolved Hide resolved
proto/evmos/incentives/v1/genesis.proto Outdated Show resolved Hide resolved
proto/evmos/incentives/v1/query.proto Outdated Show resolved Hide resolved
x/incentives/client/cli/tx.go Outdated Show resolved Hide resolved
x/incentives/client/cli/tx.go Outdated Show resolved Hide resolved
x/incentives/keeper/incentives.go Show resolved Hide resolved
x/incentives/types/interfaces.go Show resolved Hide resolved
x/incentives/types/keys.go Outdated Show resolved Hide resolved
x/incentives/types/keys.go Show resolved Hide resolved
x/incentives/types/proposal.go Outdated Show resolved Hide resolved
fedekunze
fedekunze reviewed Jan 11, 2022
View reviewed changes
app/app.go Outdated Show resolved Hide resolved
proto/evmos/incentives/v1/incentives.proto Outdated Show resolved Hide resolved
x/incentives/keeper/distribution.go Show resolved Hide resolved
x/incentives/keeper/distribution.go Outdated Show resolved Hide resolved
x/incentives/keeper/evm_hooks.go Outdated Show resolved Hide resolved
x/incentives/keeper/keeper_test.go Outdated Show resolved Hide resolved
x/incentives/keeper/keeper_test.go Outdated Show resolved Hide resolved
x/incentives/keeper/keeper_test.go Outdated Show resolved Hide resolved
x/incentives/keeper/incentives.go Outdated Show resolved Hide resolved
x/incentives/keeper/incentives.go Outdated Show resolved Hide resolved
@danburck danburck changed the title Incentives Module 'x/Incentives' module Jan 13, 2022
@danburck danburck changed the title 'x/Incentives' module x/incentives module Jan 13, 2022
fedekunze
fedekunze reviewed Jan 13, 2022
View reviewed changes
x/incentives/keeper/distribution.go Outdated Show resolved Hide resolved
x/incentives/keeper/distribution.go Outdated Show resolved Hide resolved
x/incentives/keeper/distribution.go Outdated Show resolved Hide resolved
x/incentives/keeper/evm_hooks.go Outdated Show resolved Hide resolved
x/incentives/keeper/evm_hooks.go Outdated Show resolved Hide resolved
x/incentives/types/genesis.go Outdated Show resolved Hide resolved
x/incentives/types/genesis.go Outdated Show resolved Hide resolved
x/incentives/types/keys.go Outdated Show resolved Hide resolved
x/incentives/types/keys.go Outdated Show resolved Hide resolved
x/incentives/types/interfaces.go Outdated Show resolved Hide resolved
fedekunze
fedekunze approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 💯 🎉

@fedekunze fedekunze enabled auto-merge (squash) January 13, 2022 11:26
@fedekunze fedekunze merged commit 077443f into main Jan 13, 2022
@fedekunze fedekunze deleted the incentives-module branch January 13, 2022 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fede fede fede left review comments

@ramacarlucho ramacarlucho ramacarlucho left review comments

@fedekunze fedekunze fedekunze approved these changes

@jolube jolube Awaiting requested review from jolube

@khoslaventures khoslaventures Awaiting requested review from khoslaventures

Assignees
No one assigned
Labels
CLI docs proto
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@danburck @fede @ramacarlucho @fedekunze