all: remove Tendermint's secp256k1 key support
#189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ENG-386 Support only ethereum keys for Evmos
Only support |
fedekunze
changed the title
fedekunze
requested review from
hanchon,
danburck,
jolube,
khoslaventures and
prajjwol
and removed request for
khoslaventures and
jolube
fedekunze
changed the title
secp256k1 key support
Codecov Report
@@ Coverage Diff @@
## main #189 +/- ##
==========================================
- Coverage 76.80% 76.30% -0.51%
==========================================
Files 50 51 +1
Lines 3027 3047 +20
==========================================
Hits 2325 2325
- Misses 603 623 +20
Partials 99 99
|
|
everything looking good, test it locally to generate an account with the old type and failed as expected |
hanchon
approved these changes
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #ENG-386