Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG 388 Remove governance hook from erc20 module #190

Merged
merged 4 commits into from
Jan 3, 2022

Conversation

danburck
Copy link
Contributor

@danburck danburck commented Jan 3, 2022

Description

Closes: https://linear.app/tharsis/issue/ENG-388/remove-governance-hook-from-erc20-module

The x/erc20 audit revealed, that Token Pair proposers should perform proper due diligence prior to registering the proposal. This PR removes the governance hook to streamline the proposal process.

  • impr(erc20): remove toke pair voting period param
  • impr(erc20): remove governance hook

@linear
Copy link

linear bot commented Jan 3, 2022

ENG-388 Remove governance hook from erc20 module

context: we want the proposals (especially ERC20 registration) to be properly reviewed

  • Remove param
  • Remove hook
  • Update keeper and app

@codecov
Copy link

codecov bot commented Jan 3, 2022

Codecov Report

Merging #190 (77c8999) into main (71c4413) will decrease coverage by 0.48%.
The diff coverage is 100.00%.

❗ Current head 77c8999 differs from pull request most recent head cb90f77. Consider uploading reports for the commit cb90f77 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #190      +/-   ##
==========================================
- Coverage   72.78%   72.30%   -0.49%     
==========================================
  Files          33       32       -1     
  Lines        2065     1993      -72     
==========================================
- Hits         1503     1441      -62     
+ Misses        499      491       -8     
+ Partials       63       61       -2     
Impacted Files Coverage Δ
x/erc20/keeper/keeper.go 100.00% <ø> (ø)
app/app.go 80.58% <100.00%> (-0.09%) ⬇️
x/erc20/types/params.go 100.00% <100.00%> (ø)

@github-actions github-actions bot added the CLI label Jan 3, 2022
@danburck danburck marked this pull request as ready for review January 3, 2022 14:27
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, can you add a state machine breaking changelog entry?

@danburck danburck enabled auto-merge (squash) January 3, 2022 15:30
@danburck danburck merged commit 98b060d into main Jan 3, 2022
@danburck danburck deleted the ENG-388-Remove-governance-hook-from-erc20-module branch January 3, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants