feat(stride): Stride outpost types and events #1914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vvaradinov
requested review from
MalteHerrmann and
GAtom22
and removed request for
a team
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## main #1914 +/- ##
==========================================
- Coverage 70.30% 69.80% -0.51%
==========================================
Files 319 323 +4
Lines 23574 23764 +190
==========================================
+ Hits 16574 16588 +14
- Misses 6179 6354 +175
- Partials 821 822 +1
|
GAtom22
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
LGTM! Great work @Vvaradinov !! Left a few comments
Please address the gosec warnings
0xstepit
approved these changes
Oct 19, 2023
0xstepit
reviewed
Oct 20, 2023
fedekunze
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes ENG-2216