Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(osmosis): Osmosis outpost interface and abi #1915

Merged
merged 9 commits into from Oct 20, 2023
Merged

feat(osmosis): Osmosis outpost interface and abi #1915

merged 9 commits into from Oct 20, 2023

Conversation

0xstepit
Copy link
Contributor

@0xstepit 0xstepit commented Oct 20, 2023 •
edited

Description

This PR adds Osmosis outpost interface and the associated abi.

Closes ENG-2223

@linear
Copy link

linear bot commented Oct 20, 2023

ENG-2223 👨‍💻 Implement Interface + ABI

Implement:

  • The outpost interface.
  • The ABI.

@0xstepit 0xstepit marked this pull request as ready for review October 20, 2023 08:05
@0xstepit 0xstepit requested a review from a team as a code owner October 20, 2023 08:05
@0xstepit 0xstepit requested review from Vvaradinov, GAtom22 and fedekunze and removed request for a team October 20, 2023 08:05
fedekunze
fedekunze approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with minor comments

precompiles/osmosis/IOsmosisOutpost.sol Outdated Show resolved Hide resolved
precompiles/osmosis/IOsmosisOutpost.sol Outdated Show resolved Hide resolved
Vvaradinov
Vvaradinov approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@Vvaradinov Vvaradinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left a nit

precompiles/osmosis/IOsmosisOutpost.sol Outdated Show resolved Hide resolved
precompiles/osmosis/IOsmosisOutpost.sol Outdated Show resolved Hide resolved
@fedekunze fedekunze enabled auto-merge (squash) October 20, 2023 09:01
@fedekunze fedekunze merged commit b6d02a1 into main Oct 20, 2023
24 of 25 checks passed
@fedekunze fedekunze deleted the stepit/osmosis-abi branch October 20, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vvaradinov Vvaradinov Vvaradinov approved these changes

@fedekunze fedekunze fedekunze approved these changes

@GAtom22 GAtom22 Awaiting requested review from GAtom22 GAtom22 is a code owner automatically assigned from evmos/core-engineering

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@0xstepit @Vvaradinov @fedekunze