ENG 377 Delayed malicious effects #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ENG-377 IF-ETHERMINT-06: Delayed malicious effects via the ERC20.sol implementation
|
Codecov Report
@@ Coverage Diff @@
## main #192 +/- ##
==========================================
+ Coverage 70.89% 70.95% +0.06%
==========================================
Files 32 32
Lines 2065 2090 +25
==========================================
+ Hits 1464 1483 +19
- Misses 531 535 +4
- Partials 70 72 +2
|
danburck
requested review from
fedekunze,
jolube and
khoslaventures
as code owners
fedekunze
reviewed
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: https://linear.app/tharsis/issue/ENG-377/if-ethermint-06-delayed-malicious-effects-via-the-erc20sol
This PR adds the
monitorApprovalEventchecks for nativeToken conversions in order to prevent malicious contracts to change the balances differently than expected by using theapprovemethod.