Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(osmosis): Outpost types, errors, and unit tests #1921

Merged
merged 54 commits into from Oct 25, 2023
Merged

feat(osmosis): Outpost types, errors, and unit tests #1921

merged 54 commits into from Oct 25, 2023

Conversation

0xstepit
Copy link
Contributor

@0xstepit 0xstepit commented Oct 20, 2023 •
edited

Description

This PR adds to the Osmosis precompiles:

  • types
  • errors
  • tests for both types and correct errors

Moreover, the type of slippage_percentage has been changed to have an easier validation. It is converted into string during memo construction.

Closes ENG-2225

@linear
Copy link

linear bot commented Oct 20, 2023

ENG-2225 👨‍💻 Implement types + events + errors + unit tests

@0xstepit 0xstepit changed the title feat(osmosis): Outposts types, errors, and events feat(osmosis): Outpost types, errors, and events Oct 22, 2023
fedekunze
fedekunze requested changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Minor changes requested

precompiles/outposts/osmosis/types.go Outdated Show resolved Hide resolved
precompiles/outposts/osmosis/types.go Outdated Show resolved Hide resolved
precompiles/outposts/osmosis/types.go Outdated Show resolved Hide resolved
precompiles/outposts/osmosis/types.go Outdated Show resolved Hide resolved
fedekunze
fedekunze approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great work @0xstepit. Minor comments pending

precompiles/outposts/osmosis/types_test.go Outdated Show resolved Hide resolved
precompiles/outposts/osmosis/types_test.go Outdated Show resolved Hide resolved
Vvaradinov
Vvaradinov approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@Vvaradinov Vvaradinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left one nit.

precompiles/outposts/osmosis/types.go Show resolved Hide resolved
@fedekunze fedekunze enabled auto-merge (squash) October 25, 2023 13:16
@fedekunze fedekunze merged commit 20f8720 into main Oct 25, 2023
26 of 28 checks passed
@fedekunze fedekunze deleted the stepit/osmosis-outpost-types branch October 25, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vvaradinov Vvaradinov Vvaradinov approved these changes

@fedekunze fedekunze fedekunze approved these changes

@MalteHerrmann MalteHerrmann Awaiting requested review from MalteHerrmann MalteHerrmann is a code owner automatically assigned from evmos/core-engineering

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@0xstepit @Vvaradinov @fedekunze