Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(dist): Add ClaimRewards unit and event tests #1954

Merged
merged 5 commits into from Oct 27, 2023

Conversation

Vvaradinov
Copy link
Contributor

@Vvaradinov Vvaradinov commented Oct 27, 2023

Description

This PR adds unit and event tests for the new ClaimRewards transaction in the distribution extension.


Closes ENG-2235

@Vvaradinov Vvaradinov requested a review from a team as a code owner October 27, 2023 08:54
@Vvaradinov Vvaradinov requested review from facs95 and MalteHerrmann and removed request for a team October 27, 2023 08:54
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #1954 (1167cf6) into main (61129ee) will increase coverage by 0.18%.
The diff coverage is 100.00%.

❗ Current head 1167cf6 differs from pull request most recent head 6881cd4. Consider uploading reports for the commit 6881cd4 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1954      +/-   ##
==========================================
+ Coverage   69.77%   69.95%   +0.18%     
==========================================
  Files         327      327              
  Lines       24268    24243      -25     
==========================================
+ Hits        16933    16960      +27     
+ Misses       6470     6413      -57     
- Partials      865      870       +5     
Files Coverage Δ
precompiles/distribution/tx.go 63.41% <100.00%> (+17.07%) ⬆️
precompiles/distribution/types.go 92.78% <ø> (+6.25%) ⬆️

... and 3 files with indirect coverage changes

@linear
Copy link

linear bot commented Oct 27, 2023

@fedekunze fedekunze enabled auto-merge (squash) October 27, 2023 10:52
@fedekunze fedekunze merged commit be684ed into main Oct 27, 2023
26 checks passed
@fedekunze fedekunze deleted the Vvaradinov/claim-rewards-unit-tests branch October 27, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants