imp(erc20): ERC-20 queries #1983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedekunze
requested review from
facs95 and
MalteHerrmann
and removed request for
a team
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
facs95
reviewed
Nov 2, 2023
Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com>
GAtom22
approved these changes
Nov 2, 2023
There was a problem hiding this comment.
LGTM! Great work @fedekunze!
Left one nit
Also there's a failing test in github.com/evmos/evmos/v15/precompiles/p256
Codecov Report
@@ Coverage Diff @@
## main #1983 +/- ##
==========================================
+ Coverage 69.72% 69.97% +0.25%
==========================================
Files 331 327 -4
Lines 24537 24270 -267
==========================================
- Hits 17108 16984 -124
+ Misses 6545 6415 -130
+ Partials 884 871 -13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements the queries for the ERC-20 precompile. Tests will follow up in a separate PR to ensure that returned values are the same as the
ERC20Metadata.solcontract.